nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-1863) Add JSON format dump output to readdb command
Date Mon, 23 Dec 2019 10:13:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002176#comment-17002176
] 

ASF GitHub Bot commented on NUTCH-1863:
---------------------------------------

sebastian-nagel commented on pull request #490: Fix for NUTCH-1863: Add JSON format dump output
to readdb command
URL: https://github.com/apache/nutch/pull/490#discussion_r360827172
 
 

 ##########
 File path: src/java/org/apache/nutch/crawl/CrawlDbReader.java
 ##########
 @@ -128,16 +137,37 @@ private void closeReaders() {
     readers = null;
   }
 
-  public static class CrawlDatumCsvOutputFormat extends
-      FileOutputFormat<Text, CrawlDatum> {
-    protected static class LineRecordWriter extends
-        RecordWriter<Text, CrawlDatum> {
+  public static class JsonIndenter extends MinimalPrettyPrinter {
+
+    /**
+    * 
+    */
+    private static final long serialVersionUID = -4464852619186879060L;
+
+    // @Override
 
 Review comment:
   The `@Override` annotation is definitely useful as it helps to prevent bugs with API changes/upgrades.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add JSON format dump output to readdb command
> ---------------------------------------------
>
>                 Key: NUTCH-1863
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1863
>             Project: Nutch
>          Issue Type: New Feature
>          Components: crawldb
>    Affects Versions: 2.3, 1.10
>            Reporter: Lewis John McGibbney
>            Assignee: Shashanka Balakuntala Srinivasa
>            Priority: Major
>             Fix For: 1.17
>
>
> Opening up the ability for third parties to consume Nutch crawldb data as JSON would
be a poisitive thing IMHO.
> This issue should improve the readdb functionality of both 1.X to enable JSON dumps of
crawldb data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message