ode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthieu Riou (JIRA)" <j...@apache.org>
Subject [jira] Updated: (ODE-204) Properly remove process from map of registered processes in BpelServerImpl.java (and some logging consistency)
Date Wed, 21 Nov 2007 15:49:44 GMT

     [ https://issues.apache.org/jira/browse/ODE-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthieu Riou updated ODE-204:
------------------------------

    Fix Version/s:     (was: 1.3)

> Properly remove process from map of registered processes in BpelServerImpl.java (and
some logging consistency)
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: ODE-204
>                 URL: https://issues.apache.org/jira/browse/ODE-204
>             Project: ODE
>          Issue Type: Bug
>          Components: Axis2 Integration
>    Affects Versions: 1.1
>         Environment: ODE 1.1
> Axis2 Distro 
> JDK 1.5.0_10
> Jetty 6.1.1
>            Reporter: Richard Taylor
>            Assignee: Matthieu Riou
>            Priority: Trivial
>             Fix For: 1.2
>
>         Attachments: file.patch
>
>
> First item:
>  Wanted to add consistency to the logging messages when deploying a new process
>  1. When deploying, the term "Activated" is used.  However when undeploying, the term
"Unregistered" is used.
>  2. When deploying a new process, the log says "Process foo-1 has been unregistered",
even if a no previous versions of foo were deployed. This was due to accidentally putting
the log call outside of a conditional
>  Second item:
>  I haven't seen any direct affects from this code, but it is a bit off.  "p" is never
assigned a value before being referenced.  From
>  BpelServerImpl.java:
>  ------------------------------------
>  BpelProcess p = null;
>  if (_engine != null) {
>      _engine.unregisterProcess(pid);
>      _registeredProcesses.remove(p);
>  }
>  Seems it should be something like this:
>  ------------------------------------
>  BpelProcess p = null;
>  if (_engine != null) {
>     p = _engine.unregisterProcess(pid);
>     if (p != null)
>     {
>          _registeredProcesses.remove(p);
>     }
>  }
> A patch will be attached

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message