ode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ciaran <ciar...@gmail.com>
Subject Re: [VOTE] Include event_handler_1x.patch into ODE-1.X
Date Fri, 06 Nov 2009 20:25:54 GMT
That branch currently has a rather large memory leak in it, I'd
definitely consider addressing that before
merging in substantial changes ! :)  (See my mail of 2 days ago in the
user list)
-cj.


On Fri, Nov 6, 2009 at 7:53 PM, Karthick Sankarachary
<sankarachary@intalio.com> wrote:
> Rafal,
>
> To mitigate against any potential compatibility issues, I suggest that you
> write the OutstandingRequestManager such that it works even if the new field
> that you added (i.e. _replyRid) has not been initialized. Specifically, if
> that field is null you probably want to assume that there's no reply
> corresponding to the entry in question. This sanity check will help ensure
> that instances started prior to the upgrade do not break down due to this
> change in the process model.
>
> I will hold off on my vote until after I've had a chance to review the patch
> completely.
>
> Best Regards,
> Karthick Sankarachary
>
>
> On Fri, Nov 6, 2009 at 8:55 AM, Bill McCusker <wmccusker@parasoft.com>wrote:
>
>> +1 from me
>>
>>
>> Rafal Rusin wrote:
>>
>>> Let's vote to include event_handler_1x.patch patch from here into ODE-1.X:
>>> https://issues.apache.org/jira/browse/ODE-634
>>>
>>> It may break some old instances during upgrade (but only those which 2
>>> way message exchanges, which were not completed), But I think it's
>>> worth committing.
>>>
>>> Regards,
>>>
>>>
>>
>>
>

Mime
View raw message