ode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sathwik B P <sathwik...@gmail.com>
Subject Re: [WIP] Extension Activity improvements #6
Date Sun, 29 Apr 2018 05:40:20 GMT
Hi Michael,

Seems to work now. Will ckeckin sometime.

Can you create a JIRA for the REST extension. Also explaining the design
approach would be helpful. I see that your initial commit bypasses the
JACOB.

regards,
sathwik


On Sat, Apr 28, 2018 at 12:28 AM, Michael Hahn <mhahn.dev@gmail.com> wrote:

> Hi Sathwik,
>
> I missed to add/initialize the new "mustUnderstandExtensions" field during
> migration from the old to the new OModel in "OmOld2new.java".
> Therefore, the size of the maps was different which results in a
> "non-equal" result at the DeepEqualityHelper.
>
> The latest commit should solve the issue and the tests should pass now.
>
> Best regards,
> Michael
>
>
> Am 27.04.2018 um 16:08 schrieb Sathwik B P:
>
>> Hi Micheal,
>>
>> All the tests under org.apache.ode.bpel.compiler_2_0.MigrationTest are
>> failing with this change, can you have a look.
>>
>> regards,
>> sathwik
>>
>> On Tue, Apr 24, 2018 at 1:12 PM, Michael Hahn <mhahn.dev@gmail.com>
>> wrote:
>>
>> Hi Sathwik,
>>>
>>> it is still "work in progress".
>>> I planned to apply further changes/improvements to the REST extension
>>> bundle as soon I have time.
>>> I created the PR when I recognized that I missed a commit from Tammo (
>>> https://github.com/apache/ode/commit/c927b7905dd2eada281a5e73e37381
>>> ea1dcea84f) during the migration of the extension feature into the
>>> master.
>>>
>>> If you prefer to close the PR now, you can do so since the integration of
>>> the missed commit is already there.
>>> I can then open a new PR for the REST extension improvements when they
>>> are
>>> done.
>>>
>>> Best regards,
>>> Michael
>>>
>>> -----Urspr√ľngliche Nachricht-----
>>> Von: Sathwik B P [mailto:sathwik.bp@gmail.com]
>>> Gesendet: Dienstag, 24. April 2018 08:30
>>> An: dev@ode.apache.org
>>> Betreff: [WIP] Extension Activity improvements #6
>>>
>>> Hi Micheal,
>>>
>>> What is the status on this PR.
>>> https://github.com/apache/ode/pull/6
>>>
>>> regards,
>>> sathwik
>>>
>>>
>>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message