From notifications-return-4161-apmail-ofbiz-notifications-archive=ofbiz.apache.org@ofbiz.apache.org Fri Oct 21 17:46:58 2016 Return-Path: X-Original-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Delivered-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD57E195A0 for ; Fri, 21 Oct 2016 17:46:58 +0000 (UTC) Received: (qmail 92253 invoked by uid 500); 21 Oct 2016 17:46:58 -0000 Delivered-To: apmail-ofbiz-notifications-archive@ofbiz.apache.org Received: (qmail 92226 invoked by uid 500); 21 Oct 2016 17:46:58 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 92204 invoked by uid 99); 21 Oct 2016 17:46:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Oct 2016 17:46:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 77EB22C0B04 for ; Fri, 21 Oct 2016 17:46:58 +0000 (UTC) Date: Fri, 21 Oct 2016 17:46:58 +0000 (UTC) From: "Arun Patidar (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (OFBIZ-8237) Improvements in GlFiscalType entity definition and services MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-8237. ------------------------------- Resolution: Done Fix Version/s: Upcoming Branch Committed changes in trunk at rev: 1766083. Thanks [~rahul.kushwah] and [~rishisolankii] for the contribution. > Improvements in GlFiscalType entity definition and services > ----------------------------------------------------------- > > Key: OFBIZ-8237 > URL: https://issues.apache.org/jira/browse/OFBIZ-8237 > Project: OFBiz > Issue Type: Sub-task > Components: accounting > Affects Versions: Trunk > Reporter: Rishi Solanki > Assignee: Arun Patidar > Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8237.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is optional while create service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)