ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tobias Laufkötter (JIRA) <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9445) ContentWorker#findAlternateLocaleContent(Delegator, GenericValue, Locale) does not use fallback locale
Date Tue, 04 Jul 2017 10:58:02 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Tobias Laufkötter updated OFBIZ-9445:
    Attachment: OFBIZ-9445v3.patch

The function didn't recognise if the given content was already of the right locale. So I added
it to the list of alternate locales to be taken into consideration.

This case happens if the session locale string is "de_DE", but the content's locale string
is "de".

> ContentWorker#findAlternateLocaleContent(Delegator, GenericValue, Locale) does not use
fallback locale
> ------------------------------------------------------------------------------------------------------
>                 Key: OFBIZ-9445
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9445
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Tobias Laufkötter
>         Attachments: OFBIZ-9445.patch, OFBIZ-9445v2.patch, OFBIZ-9445v3.patch
> Contrary to the UiLabels the ContentWorker#findAlternateLocaleContent(Delegator, GenericValue,
Locale) function does not default to the fallback locale if no alternate content with the
given locale is found, but returns the originial content. This proves to be an issue, if the
root content is not in the fallback language.
> For instance: if the fallback locale is set to english, the ProductContent for the PRODUCT_NAME
is in german, the alternate locale contents for the product name are english and spanish,
then an italian visitor will see the page in english, but the product names in german.
> A fix for this issue is simple:
> If no alternate locale content for the requested locale is found, search for an alternate
locale content with the locale configured in general.properties at locale.properties.fallback.
If this one isn't found either we can still return the original content.

This message was sent by Atlassian JIRA

View raw message