ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9451) [FB] Package org.apache.ofbiz.accounting.payment
Date Fri, 07 Jul 2017 10:27:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Brohl updated OFBIZ-9451:
---------------------------------
    Attachment: OFBIZ-9451_payment.BillingAccountWorker_bugfixes.patch
                OFBIZ-9451_payment.GiftCerificateServices_bugfixes.patch
                OFBIZ-9451_payment.PaymentGatewayServices_bugfixes.patch
                OFBIZ-9451_payment.PaymentMethodServices_bugfixes.patch

Here are the patches for the issues.

> [FB] Package org.apache.ofbiz.accounting.payment
> ------------------------------------------------
>
>                 Key: OFBIZ-9451
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9451
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-9451_payment.BillingAccountWorker_bugfixes.patch, OFBIZ-9451_payment.GiftCerificateServices_bugfixes.patch,
OFBIZ-9451_payment.PaymentGatewayServices_bugfixes.patch, OFBIZ-9451_payment.PaymentMethodServices_bugfixes.patch
>
>
> BillingAccountWorker:
> * Implement Serializable for class BillingAccountComparator and suppress Warnings (following
the discussion on warnings for serializable classes: http://ofbiz.135035.n4.nabble.com/Usage-of-SuppressWarnings-quot-serial-quot-td361041.html)
> GiftCertificateServices:
> * Set BigDecimal zero to final to avoid changes by malicious code from the outside or
changes that happen by accident from another package.
>     ReturnHeaderResp in RefundGcPurchase() is unnecessarily checked for null value.
> PaymentGatewayServices:
> * At two occurrences, an Error is logged which contains the variable processorResult.
At that point however processorResult is certain to be null. Remove the variable from the
log.
> * Remove unreachable else condition in processAuthResult(). authResult can only be true
or false, no third condition needed.
> PaymentMethodServices:
> * Use a StringBuilder to append a certain amount of '*'s to origMaskedNumber. When using
concatenation inside the loop, the String is converted to a new StringBuilder, appended to,
and then converted back to a String anyway. Therefor the performance is improved by avoiding
many StringBuilder initializations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message