From notifications-return-10197-apmail-ofbiz-notifications-archive=ofbiz.apache.org@ofbiz.apache.org Sat Jul 8 12:41:10 2017 Return-Path: X-Original-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Delivered-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BB371A60A for ; Sat, 8 Jul 2017 12:41:10 +0000 (UTC) Received: (qmail 33049 invoked by uid 500); 8 Jul 2017 12:41:10 -0000 Delivered-To: apmail-ofbiz-notifications-archive@ofbiz.apache.org Received: (qmail 33026 invoked by uid 500); 8 Jul 2017 12:41:10 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 33017 invoked by uid 99); 8 Jul 2017 12:41:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jul 2017 12:41:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D5C9F181294 for ; Sat, 8 Jul 2017 12:41:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id jNjzIEpBh4eN for ; Sat, 8 Jul 2017 12:41:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 05DFD5FDE4 for ; Sat, 8 Jul 2017 12:41:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7226E0D51 for ; Sat, 8 Jul 2017 12:41:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A965724698 for ; Sat, 8 Jul 2017 12:41:02 +0000 (UTC) Date: Sat, 8 Jul 2017 12:41:02 +0000 (UTC) From: "Aishwary Shrivastava (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (OFBIZ-9457) Improvements in OrderHeader entity definition and services MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aishwary Shrivastava updated OFBIZ-9457: ---------------------------------------- Attachment: OFBIZ-9457.diff Here is the patch for the Improvement. Thanks to Devanshu Vyas, Amit Gadaley, Vaibhav Jain and Rishi Solanki for the guidance. Steps to verify the changes of AddItemFromOrder: 1. Login 2.Go to Facility. 3.Go to Shipments. 4.Find an Outgoing - Sales type shipment. 5.Select the shipment. 6.Click on Order Items Steps to verify the changes of ReceiveInventoryAgainstPurchaseOrder: 1. Login 2.Go to Facility. 3.Go to Shipments. 4.Find an Incoming - Purchase type shipment. 5.Select the shipment. 6.Click on Receive against PO. The data show on the screens remains same before and after applying the patch. > Improvements in OrderHeader entity definition and services > ---------------------------------------------------------- > > Key: OFBIZ-9457 > URL: https://issues.apache.org/jira/browse/OFBIZ-9457 > Project: OFBiz > Issue Type: Sub-task > Components: order > Affects Versions: Trunk > Reporter: Rishi Solanki > Priority: Minor > Attachments: OFBIZ-9457.diff > > > Fix entity definition of OrderHeader and do the following changes in the implementation; > - Remove relations with OrderHeaderNoteView and OrderItemAndShipGroupAssoc from the entity definition. > - Check for the both views used at any place as getRelated() generic value methods on OrderHeader then change them with appropriate EntityQuery method or delegaor or other script as applicable. > - Few find areas are; > -- AddItemsFromOrder.groovy > -- ReceiveInventoryAgainstPurchaseOrder.groovy > Note: As we are removing relation from OrderHeader so only need to work on the items where we are trying to get related data by using the relations. We need to rewrite only those lines of code. Reverse in not true. -- This message was sent by Atlassian JIRA (v6.4.14#64029)