ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankush Upadhyay (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO
Date Sat, 23 Sep 2017 12:36:02 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177767#comment-16177767
] 

Ankush Upadhyay edited comment on OFBIZ-7183 at 9/23/17 12:35 PM:
------------------------------------------------------------------

I debugged into to code and found that there is no check on order item status that prevents
to render completed item on receive PO items on UI that means this issue is not specific to
Service order item and can be reproduced with FINISHED_GOOD as well.
I also found one behaviour while reviewing the code, If we partially receive some quantity
and then cancelled remaining then also system allows to receive remaining quantity and not
taking cancelled quantity into account to restrict further PO receive for that order item
even if that item is completed now.

Attaching the patch to fix both issues. 


was (Author: ankush.upadhyay):
I debugged into to code and found that there is no check on order item status that prevents
to render completed item on receive PO items on UI that means this issue is not specific to
Service order item and can be reproduced with FINISHED_GOOD as well.
I also found one behaviour while reviewing the code, If we partially receive some quantity
and then cancelled remaining then also system allows to receive remaining quantity and not
taking cancelled quantity into account to restrict further PO receive for that order item
even if that item is completed now.
!OrderItem.png|thumbnail!
!RecceiveInventory.png|thumbnail! 

I am attaching the patch to fix both issues. 

> Completed Service Order Items are being allowed to be received along with finished goods
over Approved PO 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7183
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7183
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Upcoming Release
>            Reporter: Swapnil Shah
>            Assignee: Ankush Upadhyay
>         Attachments: COMP_REC_1.png, OFBIZ-7183.patch, orderitem.jpg, OrderItem.png,
RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order items having
service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) are listed
along with finished goods to be received and eventually get received as well if done so. 
> We could try preventing service type items to be listed like we do for any regular finished
good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message