ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taher Alkhateeb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10253) Pass JVM options to OFBiz when using Gradle
Date Fri, 09 Mar 2018 10:50:01 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392700#comment-16392700

Taher Alkhateeb commented on OFBIZ-10253:

Hi Michael,

Good idea and great quality as usual. I have a few minor comments:
 - Would you consider maybe using tokenize() instead of split(). Tokenize ignores repetitive
delimiters (whitespace) and so you won't need the regex pattern. Take a look at the ofbiz
rule tasks at the bottom of the file for examples.
 - Wouldn't the documentation be more suitable in something like the "Miscellaneous Documentation"
section? I think you placed it under "Build system syntax" which is a generic syntax section,
but maybe your docs are a bit more specific?
 - If I remember correctly, I think you don't need to type "project.jvmArgs" and your can
just immediately reference jvmArgs
 - Finally, just FYI regex is native in groovy. So if you want to use it you can just do it
like /regex-here/ without quotes.

> Pass JVM options to OFBiz when using Gradle
> -------------------------------------------
>                 Key: OFBIZ-10253
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10253
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: Gradle
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: 17.12.01, 16.11.05
>         Attachments: OFBIZ-10253_pass_jvm_opts.patch
> In the current setup of Gradle, it is not possible to pass parameters to the OFBIZ JVM.
Possible parameters are passed to the Gradle wrapper but not to OFBiz.
> OFBiz only gets the hard coded jvmArguments list defined in the build file.
> I suggest to do a simple imporvement to the build.gradle file. If you pass e.g.
> {code:java}
> -PjvmArgs="-Xms1024M -Xmx2048M"{code}
> these parameters are passed to OFBiz, else the current default is passed.
> I'll provide a patch for it.
> What do you think?

This message was sent by Atlassian JIRA

View raw message