From notifications-return-17202-apmail-ofbiz-notifications-archive=ofbiz.apache.org@ofbiz.apache.org Mon Mar 19 10:19:05 2018 Return-Path: X-Original-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Delivered-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 169AB18A09 for ; Mon, 19 Mar 2018 10:19:05 +0000 (UTC) Received: (qmail 38349 invoked by uid 500); 19 Mar 2018 10:19:05 -0000 Delivered-To: apmail-ofbiz-notifications-archive@ofbiz.apache.org Received: (qmail 38216 invoked by uid 500); 19 Mar 2018 10:19:04 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 38205 invoked by uid 99); 19 Mar 2018 10:19:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 10:19:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E9B771A165A for ; Mon, 19 Mar 2018 10:19:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2heTCkkk2-hR for ; Mon, 19 Mar 2018 10:19:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D63435F6BE for ; Mon, 19 Mar 2018 10:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B9B9CE0CEF for ; Mon, 19 Mar 2018 10:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2F331214AD for ; Mon, 19 Mar 2018 10:19:00 +0000 (UTC) Date: Mon, 19 Mar 2018 10:19:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-4959) Logout do not remove autoLogin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-4959?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1640= 1683#comment-16401683 ]=20 Jacques Le Roux edited comment on OFBIZ-4959 at 3/19/18 10:18 AM: ------------------------------------------------------------------ I completed the fix in trunk r1826938 =C2=A0 R17.12 r1826939 R16.11 r1826943 I used the only available (and I must say confusing) WebappInfo.getName() w= hen I needed the webAppName not the WebappInfoName. So this put in a new=20 WebappInfo.getMountPoint() and use it in getWebappInfo Also use LoginWorker.autoLoginSet() in different places where I missed it. = In=20 other words all autoUserLogin coockies are deleted on login and logout, and an autoUserLogin cookie is created when going locally from a webapp to anot= her, with checkExternalLoginKey was (Author: jacques.le.roux): I completed the fix in trunk r1826938 =C2=A0 R17.12 r1826939 R16.11 r1826943 > Logout do not remove autoLogin > ------------------------------ > > Key: OFBIZ-4959 > URL: https://issues.apache.org/jira/browse/OFBIZ-4959 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: Release 09.04, Release 10.04 > Environment: Windows 2003 Server. Apache Ofbiz 2004 and Ofbiz 10 > Reporter: Roberto Ben=C3=ADtez Monje > Assignee: Jacques Le Roux > Priority: Major > Labels: logout, security > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-4959.patch, OFBIZ-4959.patch > > Original Estimate: 70,056h > Remaining Estimate: 70,056h > > Logout method do not disable autoLogin functionality. Instead of that it = just initializes autoLogin in session and request. > It have to be replace autoLoginCheck for autoLoginRemove inside of logout= method. > {code:title=3DLoginEvents/LoginWorker.java|borderStyle=3Dsolid} > public static String logout(HttpServletRequest request, HttpServletRespon= se response) { > =09// invalidate the security group list cache > =09GenericValue userLogin =3D (GenericValue) request.getSession().getAttr= ibute("userLogin"); > =09String returnValue =3D "success"; > =09if (request.getAttribute("_AUTO_LOGIN_LOGOUT_") =3D=3D null) { > =09=09try { > =09=09=09returnValue =3D autoLoginRemove(request, response); > =09=09} catch (IOException e) { > =09=09=09Debug.logWarning(e, "", module); > =09=09} > =09} > =09// log out from all other sessions too; do this here so that it is onl= y done when a user explicitly logs out > =09logoutFromAllSessions(userLogin); > =09doBasicLogout(userLogin, request); > =09return returnValue; > } > {code}=20 -- This message was sent by Atlassian JIRA (v7.6.3#76005)