ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10338) Confusing entity names
Date Thu, 12 Apr 2018 11:16:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435365#comment-16435365

Jacques Le Roux commented on OFBIZ-10338:

Hi Suraj,

The current discussion is at https://markmail.org/message/7fbgu77gey6ymefm
This needs to get a wider consensus. We need to take time before any action. The implications
are wide...

> Confusing entity names
> ----------------------
>                 Key: OFBIZ-10338
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10338
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
> There are some entities which could be renamed as per their usage.
>  * *OrderItemShipGroup*: It shows order ship groups and it doesn't contain anything at
order item level. So, it could be re-named as *OrderShipGroup.*
>  * *OrderItemShipGroupAssoc:* It do not maintain any association type, it just contains
order item with respect to ship group, so this could be re-named as *OrderShipGroupItem* to
maintain consistency and code readablity.
> There is a discussion as well on Dev ML regarding this improvement. 

This message was sent by Atlassian JIRA

View raw message