ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-10413) Remove unused code in `CommonEvents::setFollowerPage`
Date Thu, 14 Jun 2018 13:22:01 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacques Le Roux closed OFBIZ-10413.
-----------------------------------
    Resolution: Done

Hi Mathieu,

After investigatin a bit more, I found that it's not related with the data model at all and
the attribute "visid" is never used.

Also this event method is never used because the pushPage request map is never used. So we
can get rid of the whole.

Done at revision: 1833505  

Thanks for your initial reporting

> Remove unused code in `CommonEvents::setFollowerPage`
> -----------------------------------------------------
>
>                 Key: OFBIZ-10413
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10413
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-10413-Improve-setFollowerPage.patch
>
>
> `CommonEvents::setFollowerPage` contains two unused variable definition.  After basic
search I found that this request handler is used only in `webapp/partymgr/controller.xml`
however I was unable to understand its purpose, so I have added a comment to add some kind
of docstring.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message