ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Danny Trunk (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
Date Wed, 27 Feb 2019 11:51:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779173#comment-16779173
] 

Danny Trunk edited comment on OFBIZ-10842 at 2/27/19 11:50 AM:
---------------------------------------------------------------

I was thinking about this as well when creating the issue, but I think it is a bug. As mentioned
in [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347]
it is looking for a userLogin in context which is never set before. I did a workaround in
my customPriceCalcService for now as we are using Spring Security. You can also consider it
as an improvement if you want. It's up to you.


was (Author: dtrunk90):
I was thinking about this as well when creating the issue, but I think it is a bug. As mentioned
in [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347]
it is looking for a userLogin in context which is never set before. I did a workaround in
my customPriceCalcService for now as we are using Spring Security. You can also consider it
as an improvement if you want.

> No userLogin given in calculateProductPrice service call context
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-10842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10842
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, product
>    Affects Versions: Trunk
>            Reporter: Danny Trunk
>            Assignee: Jacques Le Roux
>            Priority: Major
>
> The call context for calculateProductPrice doesn't contain the userLogin:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195]
> As this is needed in the customPriceCalcService:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347]
>  
> So currently there's no chance to get the user information in a custom price calc service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message