ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shi Jinghai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL
Date Sat, 02 Mar 2019 14:36:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782398#comment-16782398
] 

Shi Jinghai commented on OFBIZ-10700:
-------------------------------------

Hi Mathieu,

Brilliant!

I suggest change 
{code:java}
if (project.hasProperty('enableOwasp')) {
    plugins {
        id 'org.owasp.dependencycheck' version '3.0.2'
    }
}{code}
to 
{code:java}
plugins {
...
    id "org.owasp.dependencycheck" version "3.0.2" apply false
}

if (project.hasProperty('enableOwasp')) {
    apply plugin: 'org.owasp.dependencycheck'
}{code}
What do you think?

Kind Regards,

> Use the Gradle Plugin DSL
> -------------------------
>
>                 Key: OFBIZ-10700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10700
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See [here|https://docs.gradle.org/current/userguide/plugins.html]
for more details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message