ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suraj Khurana (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10811) PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables
Date Sat, 09 Mar 2019 05:02:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788489#comment-16788489
] 

Suraj Khurana commented on OFBIZ-10811:
---------------------------------------

Thanks Jacques for your concerns:
 # Why a try block for captureAmount and not processAmount?
 # Why a try block for the 1st processAmount and not the 2nd?

Shifted same try block to cover ObjectTypeConvert exception as well with General exception.

Removing try block for pay to party as in refundPayment service payToPartyId is going to
be actually order's billToParty and getBillingInformation is doing so many unnecessary things
which are not used in this service context so simply replacing it.

HTH.

Please let us know in case of any further concerns.

 

> PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables
> --------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10811
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-10811.patch
>
>
> Currently, it is direct typecasting into BigDecimal and it could throw exception regarding
string to BigDecimal typecasting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message