ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Malin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
Date Sat, 20 Jul 2019 07:14:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889397#comment-16889397

Nicolas Malin commented on OFBIZ-7532:

I created a new patch [^OFBIZ-7532.patch] to continue to homogenize number displaying format
with :
 * move properties on common/config/number.properties (I open to another name if you have)
 * create new OfbizNumberTransform to call on ftl the displaying by <@ofbizNumber number=size
format='quantity' />
 * change OfbizAmountTransform to extend OfbizNumberTransform with format='amount' and keep
backward compatibility to use amount argument instead number
 * change format-type to format on xsd to keep same naming with ftl rendering
 * add some example on Quote's screen

I think this version is ready to commit, If no remarks I will load it on trunk

> Form Display Field improvement to manage multiple number format
> ---------------------------------------------------------------
>                 Key: OFBIZ-7532
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7532
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Charles STELTZLEN
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, OFBIZ-7532.patch, Sélection_238.png
> On display field used in forms, there is a "type" "accounting-number" which is used to
format number like property configuration :  #,##0.0000;(#,##0.0000).
> This JIRA propose to extend this idea by using a "type" "number" and an additional attribute
called "format-pattern". This field will be used by form renderer to get the good property.
It use FlexibleString to manage variable in this field and so allow to have different format
for the same column according to some conditions.
> example: <field name="amount"><display type="number" format-pattern="accounting"/></field>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.0000;(#,##0.0000)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using EntityUtilProperties.getPropertyValue
to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the choices.

This message was sent by Atlassian JIRA

View raw message