ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
Date Sun, 21 Jul 2019 10:16:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889705#comment-16889705

Jacques Le Roux commented on OFBIZ-7532:

Hi Nicolas,

I'm cursorily reviewing, It seems you missed to add the common/config/number.properties file
in the patch. I have also an issue applying the patch with UtilFormatOut class. I guess you
need to update after Mathieu's recent changes.

> Form Display Field improvement to manage multiple number format
> ---------------------------------------------------------------
>                 Key: OFBIZ-7532
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7532
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Charles STELTZLEN
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, OFBIZ-7532.patch, Sélection_238.png
> On display field used in forms, there is a "type" "accounting-number" which is used to
format number like property configuration :  #,##0.0000;(#,##0.0000).
> This JIRA propose to extend this idea by using a "type" "number" and an additional attribute
called "format-pattern". This field will be used by form renderer to get the good property.
It use FlexibleString to manage variable in this field and so allow to have different format
for the same column according to some conditions.
> example: <field name="amount"><display type="number" format-pattern="accounting"/></field>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format 
> default.number.format = ##0.00
> accounting.number.format = #,##0.0000;(#,##0.0000)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using EntityUtilProperties.getPropertyValue
to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the choices.

This message was sent by Atlassian JIRA

View raw message