ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10753) Improve error message page to support Theming
Date Thu, 12 Sep 2019 08:11:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928347#comment-16928347
] 

Jacques Le Roux commented on OFBIZ-10753:
-----------------------------------------

Hi Nicolas, I was wondering: can't this be applied to plugins?

> Improve error message page to support Theming
> ---------------------------------------------
>
>                 Key: OFBIZ-10753
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10753
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>         Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> <errorpage>/error/error.jsp</errorpage>{code}
> This method isn't support by the theming. I propose two improvements :
>  * use FlexibleLocation to resolve the error page :
> {code:java}
> <errorpage>component://common/webcommon/error/error.ftl</errorpage>{code}
>  * improve theme to support the error message page   
> {code:java}
>   <template name="screen" type="html" content-type="UTF-8" encoding="none" encoder="html"
compress="false">
>   <template-file widget="screen" location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>   <template-file widget="form" location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>   <template-file widget="tree" location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>   <template-file widget="menu" location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + <template-file widget="error" location="component://common-theme/template/ErrorPage.ftl"/>
> </template>{code}
> By the way you can define your error page by the theme in first step and we would use
the rendering type in future to display the error no only in html



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message