ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mathieu Lirzin (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-commit on every committer machine
Date Sat, 07 Dec 2019 15:27:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990515#comment-16990515

Mathieu Lirzin commented on OFBIZ-11304:

Hello [~jleroux],

I like the idea of automating the execution of {{gradlew check}}. However since this is not
a cheap operation (it makes my 8 core CPU heat and pur) it might be a bit too much to run
it before each commit. Maybe we could delay the execution to the [pre push|https://www.git-scm.com/docs/githooks#_pre_push]
phase or later.

What do you think?

> Install a Checkstyle pre-commit on every committer machine
> ----------------------------------------------------------
>                 Key: OFBIZ-11304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11304
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check
gradle task. It's "hard" to exactly know from where lint errors  come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350
to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when
a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone with some
committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx.
Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3

This message was sent by Atlassian Jira

View raw message