ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Samuel Trégouët (Jira) <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-commit on every committer machine
Date Sat, 07 Dec 2019 20:36:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990608#comment-16990608

Samuel Trégouët commented on OFBIZ-11304:

I think a better option is to run checkstyle (and maybe other automatic test) in ofbiz infra,
but not only on trunk (as it is already done) but also on every patch submission (think of
checks run on every pull request for a github project). So committer can easily see if a new
patch will break something on trunk.

> Install a Checkstyle pre-commit on every committer machine
> ----------------------------------------------------------
>                 Key: OFBIZ-11304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11304
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check
gradle task. It's "hard" to exactly know from where lint errors  come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350
to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when
a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone with some
committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx.
Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3

This message was sent by Atlassian Jira

View raw message