ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10091) Unnecessary throws clauses in renderer classes?
Date Sat, 01 Feb 2020 14:06:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028095#comment-17028095
] 

Michael Brohl commented on OFBIZ-10091:
---------------------------------------

Will work on this.

> Unnecessary throws clauses in renderer classes?
> -----------------------------------------------
>
>                 Key: OFBIZ-10091
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10091
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> During the refactoring work I found that there are several classes in org.apache.ofbiz.widget.renderer.macro
which state in their method declarations that they throw TemplateException and/or IOException.
> In many cases, there is either no evidence of these Exceptions or they are catched inside
the methods.
> One example is the MacroFormRenderer constructor which says it throws TemplateException
but does not.
> The method declarations in the interfaces of org.apache.ofbiz.widget.renderer all say
that IOException is thrown.
> It might be that I overlook something and I did not dig much deeper into the code so
I first want to ask what the reasons are or if it would not be reasonable to make a difference
in interfaces and implementations and only declare that a method throws a specific exception
if it really does?
> Thanks for your help,
> regards,
> Michael



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message