ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-10772) OFBiz On a Diet
Date Sat, 01 Feb 2020 14:23:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028104#comment-17028104

Michael Brohl commented on OFBIZ-10772:

[~pierresmits], do you want to work on this by starting a discussion and get consensus to
do  any of the action items?

It's over a year and nothing seems to happen. thanks for your feedback.

> OFBiz On a Diet
> ---------------
>                 Key: OFBIZ-10772
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10772
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Minor
> OFBiz is laden with superfluous redundancies and approaches for 'novice' developers,
when it comes to handling labels (titles) for screens and fields in forms in both Freemarker
templates and widgets.
> In screens we have defined elements such as: 
> {code:java}
> <set field="titleProperty" value="ManufacturingCreateProductionRun"/>
> {code}
> and
> {code:java}
> <screenlet title="${uiLabelMap.PageTitleAddFeatureInterAction"}">
> {code}
> Equally so we have defined elements in widget forms and templates, such as:
> {code:java}
> ${uiLabelMap.FormFieldTitle_<WhatEverTheFieldNameIs>}
> {code}
> or
> {code:java}
> ${uiLabelMap.<ComponentName><VeryLenghtyExplanationAsLabelForAField>}
> {code}
> This all has led to a situation where we have a product that, label-wise, overflown with
exceptions on exceptions, and unnecessary 'explanations' - such as the 'componentName', or
'PageTitle' or 'FormFieldTitle_', in any of the files.
> Equally so, having to have the name of the component in the identifier of a label is
unnecessary and reduces reuse. An 'Amount' label has the same meaning everywhere (given its
context), so there is no need to have definitions like:
>  * AccountingAmount
>  * PaymentAmount
>  * ProductAmount
>  * OrderAmount
>  * TermAmount
>  * FormFieldTitle_amount
>  * etc.
> Having done a quick assessment I get to over 90.000 unnecessary identifiers in our files
that  hampers us in reusing labels as much as possible.
> We can save 100.000s of bytes in our product by removing these unnecessary 'novice' developer
requirements, resulting in cost- and time-saving benefits for our adopters, their developers
and our contributors.
> This is the umbrella ticket to capture related sub-tasks (tickets/sub-tasks).

This message was sent by Atlassian Jira

View raw message