ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11306) POC for CSRF Token
Date Thu, 06 Feb 2020 21:49:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031966#comment-17031966
] 

Jacques Le Roux commented on OFBIZ-11306:
-----------------------------------------

bq. What if someone clears the cache through the webtools?

I'm still reviewing, as James wrote that I'll let him have the last words. In dev and demo
mode the CSRF defense should not be used, so not a concern there. 

If in production for a reason you need to clear all caches, it's a problem. We could use another
LinkedHashMap of the same type than the UtilCache with another removeEldestEntry method. 

This said you can certainly clear all caches by hand. But, as long as you know which cache/s
you need tp clear, that would be a mistake and is not recommended. If ever someone does that
then, among other possible issues, all the tokens will be lost and users in the middle of
a request will have to get another one by clicking on a link asking them to do so, not a good
user experience...The best way to clear cache/s is to clear only the cache/s that you really
need to clear. 



> POC for CSRF Token
> ------------------
>
>                 Key: OFBIZ-11306
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11306
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Upcoming Branch
>            Reporter: James Yong
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: CSRF
>             Fix For: Upcoming Branch
>
>         Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, CsrfUtil.java,
OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
OFBIZ-11306_Plugins.patch
>
>
> CRSF tokens are generated using SecureRandom class (maybe later a JWT with a "time out").

> They are stored in the user sessions (for AJAX calls and unauthenticated HTTP calls)
or OFBiz UtilCache (for authenticated HTTP calls), and verified during POST request.
> # In *controllers* a new csrf-token attribute is added to the security tag to exempt
or force CSRF token check. 
> # In *Widget Forms* a hidden token field is auto-generated.
> # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the change.
Using <@ofbizUrl> macro to generate the CSRF token means there is no need to manually
add the CSRF token field to each form in the ftl files. It will save time for users doing
custom implementation and maintenance.  While there is CSRF token in the form URL, the token
is invalidated during form submission. So it's uniqueand harmless even though the CSRF token
of the form submission is shown in the browser address bar.
> # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added through
OfbizUtil.js (itself called at start in decorators and such)
> # The html metadata is storing the csrf token used by JQuery AJAX. This token will not
change to another value after it is consumed
> # Csrf tokens for the user are removed from the UtilCache when the user logs out or session
invalidated.
> The general rule are as follows:
> * RequestMap configured with 'get' method will be exempted from CSRF token check.
> * RequestMap configured with 'post' or 'all' method will be subjected to CSRF token check.
(Note there are discussions that RequestMap with ‘all’ method should also not be subjected
to CSRF token check. This will be done after ensuring a separate uri is used when posting
changes.)
> * "main" request URIs are exempted from CSRF token check.
> * Setting csrf-token to false or true on the Request Map will override the general rules
above.
> To implement:
> * -Allow token map size to be configurable in properties.- OK that's done locally
> To Discuss:
> * Invalidate authenticated user session when CSRF token check fails.
> * Configure the general rules in a Service method (which will be run inside the constructor
of RequestMap class) when determining the final securityCsrfToken value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message