ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-11351) Adjust checkstyle configuration
Date Sat, 22 Feb 2020 17:52:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-11351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Michael Brohl closed OFBIZ-11351.
    Resolution: Won't Do

The change does not seem to be in favor of the community, see discussion at [https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E]

Closing for now.


> Adjust checkstyle configuration
> -------------------------------
>                 Key: OFBIZ-11351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11351
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: Gradle
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-11351_constant_names_adjust.patch
> We should take an approach to fine-tune the configuration so that it better fits the
project style.
> As an example, constants are currently not allowed to be named "module", "resource" etc.
which is a common pattern in our code. Changing from ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$ to ^[a-zA-Z][a-zA-Z0-9]*(_[a-zA-Z0-9]+)*$
would allow the common naming.
> Adjustments should be proposed here and decided upon.

This message was sent by Atlassian Jira

View raw message