ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11351) Adjust checkstyle configuration
Date Thu, 13 Feb 2020 17:37:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036370#comment-17036370
] 

Michael Brohl commented on OFBIZ-11351:
---------------------------------------

Constant names adjustment from ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)+_*_$ to ^[a-zA-Z][a-zA-Z0-9]*(*_*[a-zA-Z0-9])*$

error files / count

before: 956 / 34566

after: 952 / 33282

> Adjust checkstyle configuration
> -------------------------------
>
>                 Key: OFBIZ-11351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11351
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: Gradle
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-11351_constant_names_adjust.patch
>
>
> We should take an approach to fine-tune the configuration so that it better fits the
project style.
> As an example, constants are currently not allowed to be named "module", "resource" etc.
which is a common pattern in our code. Changing from ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$ to ^[a-zA-Z][a-zA-Z0-9]*(_[a-zA-Z0-9]+)*$
would allow the common naming.
> Adjustments should be proposed here and decided upon.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message