From notifications-return-30385-apmail-ofbiz-notifications-archive=ofbiz.apache.org@ofbiz.apache.org Wed Feb 5 16:03:02 2020 Return-Path: X-Original-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Delivered-To: apmail-ofbiz-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id D782D19DC3 for ; Wed, 5 Feb 2020 16:03:01 +0000 (UTC) Received: (qmail 59315 invoked by uid 500); 5 Feb 2020 16:03:01 -0000 Delivered-To: apmail-ofbiz-notifications-archive@ofbiz.apache.org Received: (qmail 59290 invoked by uid 500); 5 Feb 2020 16:03:01 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 59280 invoked by uid 99); 5 Feb 2020 16:03:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2020 16:03:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 98836E0F8F for ; Wed, 5 Feb 2020 16:03:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 14D2B780109 for ; Wed, 5 Feb 2020 16:03:00 +0000 (UTC) Date: Wed, 5 Feb 2020 16:03:00 +0000 (UTC) From: "James Yong (Jira)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-11335) Add CommonForms as template pattern configured by theme MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OFBIZ-11335?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D170= 30759#comment-17030759 ]=20 James Yong commented on OFBIZ-11335: ------------------------------------ Thanks for the improvement. Tested ok with the patch. Given a form widget, how do I know whether to extend with CommonSimpleSingl= e or CommonBasicSingle ? > Add CommonForms as template pattern configured by theme > ------------------------------------------------------- > > Key: OFBIZ-11335 > URL: https://issues.apache.org/jira/browse/OFBIZ-11335 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes > Affects Versions: Trunk > Reporter: Nicolas Malin > Assignee: Nicolas Malin > Priority: Major > Attachments: OFBIZ-11335.patch > > > Currently on OFBiz we implemented a process to define some different scre= en and menu that can be implemented by the theming > But for the form we have nothing. All style are hard coded on each > {code:java} > odd-row-style=3D"alternate-row" default-table-style=3D"basic-table hover= -bar">{code} > =C2=A0 > I propose to extend the theming implementation principle to forms element= . > To start low, I define seven form tempates : > * grid CommonSimpleGrid > * grid CommonBasicGrid > * form CommonSimpleList > * form CommonBasicList > * form CommonInLineEditList > * form CommonSimpleSingle > * form CommonBasicSingle > =C2=A0 > We can use its like : > {code:java} >
The main difficulty raise to this task was propage the visualTheme during= the ModelForm intanciation, because we need to load wiget style (and some = other information wanted on the template) on model load in memory.=20 > With the linked patch I improved form present on screen=20 > [https://localhost:8443/webtools/control/WebtoolsLayoutDemo] > =C2=A0 > Finally with this we can extend style form (pagination, header, line and = so on ...) direclty by your theme without change the framework -- This message was sent by Atlassian Jira (v8.3.4#803005)