ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Foxworthy (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
Date Wed, 04 Mar 2020 02:34:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050707#comment-17050707
] 

Paul Foxworthy edited comment on OFBIZ-11229 at 3/4/20 2:33 AM:
----------------------------------------------------------------

Back in OFBIZ-5312 [~jleroux] asked:
{quote}Good, clean URLs are beneficial for all of OFBiz, not just e-commerce, not just product
information.
{quote}
??Do you think we need to apply the same scheme everywhere? Even in backend???

Yes. It would certainly help for RESTful services. I'll repeat what I said earlier: URLs are
for people, not just computers.
{quote}The solution is to add a canonical URL link ([https://en.wikipedia.org/wiki/Canonical_link_element])
to the content, to make clear the primary URL and to make clear alternative URLs are just
that, alternative paths to the same thing.
{quote}
??That's quite a good idea, have you an idea on how to implement that in OFBiz???

Most OFBiz pages will have only one URL, so no canonical URL element is necessary. So we can
restrict it to entities that might have duplicate URLs. The prime example is Product. So if
we add a canonical for that using the OFBiz productId, that might be all that is needed.

Down the track, URLs like mybiz.com/employee/1234 and mybiz.com/customer/1234 might be interesting,
but that can wait until after products.


was (Author: paul_foxworthy):
Back in OFBIZ-5312 [~jleroux] asked:

 
{quote}Good, clean URLs are beneficial for all of OFBiz, not just e-commerce, not just product
information.
{quote}
??Do you think we need to apply the same scheme everywhere? Even in backend???

Yes. It would certainly help for RESTful services. I'll repeat what I said earlier: URLs are
for people, not just computers.
{quote}The solution is to add a canonical URL link ([https://en.wikipedia.org/wiki/Canonical_link_element])
to the content, to make clear the primary URL and to make clear alternative URLs are just
that, alternative paths to the same thing.
{quote}
??That's quite a good idea, have you an idea on how to implement that in OFBiz???

Most OFBiz pages will have only one URL, so no canonical URL element is necessary. So we can
restrict it to entities that might have duplicate URLs. The prime example is Product. So if
we add a canonical for that using the OFBiz productId, that might be all that is needed.

Down the track, URLs like mybiz.com/employee/1234 and mybiz.com/customer/1234 might be interesting,
but that can wait until after products.

> Merge UrlRegexpTransform and OfbizUrlTransform classes
> ------------------------------------------------------
>
>                 Key: OFBIZ-11229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch, OfbizUrlTransform vs
UrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used it everywhere.
Now there are maybe few features in OfbizUrlTransform that are not in UrlRegexpTransform.
That needs to be checked. If we can merge OfbizUrlTransform in UrlRegexpTransform then the
later could be used everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message