ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
Date Wed, 04 Mar 2020 08:17:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050988#comment-17050988
] 

Jacques Le Roux commented on OFBIZ-11229:
-----------------------------------------

bq. Most OFBiz pages will have only one URL, so no canonical URL element is necessary. So
we can restrict it to entities that might have duplicate URLs. The prime example is Product.
So if we add a canonical for that using the OFBiz productId, that might be all that is needed.

Interesting, thanks Paul

> Merge UrlRegexpTransform and OfbizUrlTransform classes
> ------------------------------------------------------
>
>                 Key: OFBIZ-11229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch, OfbizUrlTransform vs
UrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used it everywhere.
Now there are maybe few features in OfbizUrlTransform that are not in UrlRegexpTransform.
That needs to be checked. If we can merge OfbizUrlTransform in UrlRegexpTransform then the
later could be used everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message