ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre Smits (Jira)" <j...@apache.org>
Subject [jira] [Assigned] (OFBIZ-11430) getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found
Date Sun, 01 Mar 2020 09:47:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pierre Smits reassigned OFBIZ-11430:
------------------------------------

    Assignee: Pierre Smits

> getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found
> --------------------------------------------------------------------------------
>
>                 Key: OFBIZ-11430
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11430
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: bi
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>              Labels: refactoring
>
> Currently the 'getDimensionIdFromNaturalKey' function in DimensionServices.java returns
the DimensionId when found with following code excerpt
> {code:java}
> if (UtilValidate.isNotEmpty(lastDimensionValue)) {
>             resultMap.put("dimensionId", lastDimensionValue.getString("dimensionId"));
>         }
> return resultMap;
> {code}
> And when not found it returns an empty result, leaving the using function upstream to
set the '_NF' value. 
> The 'getDimensionIdFromNaturalKey' function should return the 'NF' value when no matching
dimensionId is found. 
> This would simplify the upstream code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message