ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rishi Solanki (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11431) InvoiceItem: uomID is wrongly defined
Date Wed, 04 Mar 2020 12:00:03 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051140#comment-17051140
] 

Rishi Solanki commented on OFBIZ-11431:
---------------------------------------

I would say, if this change is acceptable then we should start using the prefixUomId to give
clear indication to user of the code which UOM can be used for a particular field.

But I am not aware of the this field usage, and demo data says previously it was used for
currency. So changing UI, and having data migration script will complete the work.

What if some user already used it in old fashion then migration won't work IMO. With some
agreement on this chane I tend to agreed on the point migration does not resolve if someone
start using it incorrectly in 16R, 17R and older releases.

> InvoiceItem: uomID is wrongly defined
> -------------------------------------
>
>                 Key: OFBIZ-11431
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11431
>             Project: OFBiz
>          Issue Type: Bug
>          Components: datamodel
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Critical
>              Labels: refactoring
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the InvoiceItem entity has the field uomId, per:
> {code:java}
>       <field name="uomId" type="id"></field>
> {code}
> per the demo data this field is used to capture the currency of the invoice item. This
is, however, wrong. The currency for invoice items is set in the invoice entity record (with
field currencyUomId. 
> The uomId in the invoice item is related to the quantity set, and must be correctly named:
'quantityUomId.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message