ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre Smits (Jira)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-11458) Alignment of style.css across themes regarding 'alignment properties'.
Date Mon, 23 Mar 2020 16:32:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064929#comment-17064929

Pierre Smits commented on OFBIZ-11458:

Hi Jacques,

I wanted to achieve 2 things here:
* bring the styles more inline to css conventions (see https://www.w3schools.com/cssref/pr_text_text-align.asp
and https://www.w3schools.com/cssref/pr_pos_vertical-align.asp) without going beyond what
is commonly defined in the code base. Hence the additions in the css files of the themes.
* bring what is used in grid/form widgets and ftl templates closer to the base. Hence the
change over from align-float to align-text, as both have the same attributes. Followed by
the removal of the same in the css files of the theme.

I did a find/search (re the align-float) before and after the changes, and I did not find
any residual after the change.

> Alignment of style.css across themes regarding 'alignment properties'.
> ----------------------------------------------------------------------
>                 Key: OFBIZ-11458
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11458
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: themes
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Major
>              Labels: refactoring
>          Time Spent: 10m
>  Remaining Estimate: 0h
> Simplifying the code base regarding css style properties applied.

This message was sent by Atlassian Jira

View raw message