oodt-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nesbert Hidalgo (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OODT-478) Balance: New hook for hooks.php
Date Mon, 30 Jul 2012 20:29:34 GMT

     [ https://issues.apache.org/jira/browse/OODT-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nesbert Hidalgo updated OODT-478:
---------------------------------

    Attachment: BalanceHookBeforeAll20120730.patch.diff

Updated patch with new hook_before_all plus documentation.

I agree that the existing 'hook_before_send' and 'hook_after_send' hooks could also be used
for both types of requests. But like you said would require updating the ApplicationResponse's
"send" method as it currently only checks & executes these hooks for view requests.

I too have not used either of these hooks :)
                
> Balance: New hook for hooks.php
> -------------------------------
>
>                 Key: OODT-478
>                 URL: https://issues.apache.org/jira/browse/OODT-478
>             Project: OODT
>          Issue Type: New Feature
>          Components: balance
>    Affects Versions: 0.4
>            Reporter: Nesbert Hidalgo
>            Assignee: Andrew Hart
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: BalanceHookBeforeAll.patch.diff, BalanceHookBeforeAll20120730.patch.diff
>
>
> I would like to recommend adding an additional hook "hook_before_all" to Balance. Currently,
the hooks (hook_before_header, hook_before_view, hook_before_footer, hook_before_send) if
defined are called for views only. In my case I would like a callback to be executed for both
views and scripts. This will allow us to execute the same logic for both views and scripts.
> <?php
> // Additional callback for hooks.php
> /**
>  * hook_before_all
>  *
>  * This is the first hook called for both views and scripts (*.do).
>  */
> function hook_before_all() {}
> ?>
> Please see attached patch...
> Cheers & Thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message