oozie-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gezap...@apache.org
Subject oozie git commit: OOZIE-2931 Fix warnings during build for "no @param for" (Artem Ervits via gezapeti)
Date Wed, 02 Aug 2017 08:21:59 GMT
Repository: oozie
Updated Branches:
  refs/heads/master 018261023 -> d6d34022b


OOZIE-2931 Fix warnings during build for "no @param for" (Artem Ervits via gezapeti)


Project: http://git-wip-us.apache.org/repos/asf/oozie/repo
Commit: http://git-wip-us.apache.org/repos/asf/oozie/commit/d6d34022
Tree: http://git-wip-us.apache.org/repos/asf/oozie/tree/d6d34022
Diff: http://git-wip-us.apache.org/repos/asf/oozie/diff/d6d34022

Branch: refs/heads/master
Commit: d6d34022bafa2fa7847c779fa500e8166a49d440
Parents: 0182610
Author: Gezapeti Cseh <gezapeti@gmail.com>
Authored: Wed Aug 2 10:21:50 2017 +0200
Committer: Gezapeti Cseh <gezapeti@gmail.com>
Committed: Wed Aug 2 10:21:50 2017 +0200

----------------------------------------------------------------------
 client/src/main/java/org/apache/oozie/cli/OozieCLI.java         | 1 +
 client/src/main/java/org/apache/oozie/client/OozieClient.java   | 5 +++++
 client/src/main/java/org/apache/oozie/client/XOozieClient.java  | 3 ++-
 .../org/apache/oozie/client/event/jms/MessageDeserializer.java  | 1 +
 .../apache/oozie/action/hadoop/CredentialsProviderFactory.java  | 1 +
 .../java/org/apache/oozie/action/hadoop/FsActionExecutor.java   | 1 +
 .../java/org/apache/oozie/action/hadoop/JavaActionExecutor.java | 4 +++-
 .../java/org/apache/oozie/action/ssh/SshActionExecutor.java     | 4 ++++
 release-log.txt                                                 | 1 +
 9 files changed, 19 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
----------------------------------------------------------------------
diff --git a/client/src/main/java/org/apache/oozie/cli/OozieCLI.java b/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
index a545754..d837c84 100644
--- a/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
+++ b/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
@@ -547,6 +547,7 @@ public class OozieCLI {
 
     /**
      * Create option for command line option 'pig' or 'hive'
+     * @param jobType
      * @return pig or hive options
      */
     @SuppressWarnings("static-access")

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/client/src/main/java/org/apache/oozie/client/OozieClient.java
----------------------------------------------------------------------
diff --git a/client/src/main/java/org/apache/oozie/client/OozieClient.java b/client/src/main/java/org/apache/oozie/client/OozieClient.java
index b989a33..d53ca3d 100644
--- a/client/src/main/java/org/apache/oozie/client/OozieClient.java
+++ b/client/src/main/java/org/apache/oozie/client/OozieClient.java
@@ -256,6 +256,7 @@ public class OozieClient {
      * IMPORTANT: impersonation happens only with Oozie client requests done within
      * doAs() calls.
      *
+     * @param <T>
      * @param userName user to impersonate.
      * @param callable callable with {@link OozieClient} calls impersonating the specified
user.
      * @return any response returned by the {@link Callable#call()} method.
@@ -1242,6 +1243,7 @@ public class OozieClient {
      * @param jobId
      * @param actionList
      * @param dates
+     * @param ps
      * @throws OozieClientException
      */
     public void getCoordActionMissingDependencies(String jobId, String actionList, String
dates, PrintStream ps)
@@ -1829,6 +1831,8 @@ public class OozieClient {
      * @param refresh true if -refresh is given in command option
      * @param noCleanup true if -nocleanup is given in command option
      * @param failed true if -failed is given in command option
+     * @param props
+     * @return new coordinator job execution
      * @throws OozieClientException
      */
     public List<CoordinatorAction> reRunCoord(String jobId, String rerunType, String
scope, boolean refresh,
@@ -2022,6 +2026,7 @@ public class OozieClient {
     *
     * @param start starting offset
     * @param len number of results
+     * @param filter
     * @throws OozieClientException
     */
         public void getSlaInfo(int start, int len, String filter) throws OozieClientException
{

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/client/src/main/java/org/apache/oozie/client/XOozieClient.java
----------------------------------------------------------------------
diff --git a/client/src/main/java/org/apache/oozie/client/XOozieClient.java b/client/src/main/java/org/apache/oozie/client/XOozieClient.java
index 799208a..ba60f8e 100644
--- a/client/src/main/java/org/apache/oozie/client/XOozieClient.java
+++ b/client/src/main/java/org/apache/oozie/client/XOozieClient.java
@@ -193,7 +193,8 @@ public class XOozieClient extends OozieClient {
      * @throws java.io.IOException thrown if there is a problem with file.
      * @throws OozieClientException thrown if the job could not be submitted.
      */
-    public String submitScriptLanguage(Properties conf, String scriptFile, String[] args,
String[] params, String jobType)
+    public String submitScriptLanguage(Properties conf, String scriptFile, String[] args,
String[] params,
+        String jobType)
             throws IOException, OozieClientException {
         OozieClient.notNull(conf, "conf");
         OozieClient.notNull(scriptFile, "scriptFile");

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
----------------------------------------------------------------------
diff --git a/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
b/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
index 8337baf..fe31061 100644
--- a/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
+++ b/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
@@ -36,6 +36,7 @@ public abstract class MessageDeserializer {
     /**
      * Constructs the event message from JMS message
      *
+     * @param <T>
      * @param message the JMS message
      * @return EventMessage
      * @throws JMSException

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
b/core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
index ddffc79..5ca8d3e 100644
--- a/core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
+++ b/core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
@@ -75,6 +75,7 @@ public class CredentialsProviderFactory {
     /**
      * Create Credential object
      *
+     * @param type
      * @return Credential object
      * @throws Exception
      */

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java b/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
index bf022d5..63f6104 100644
--- a/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
+++ b/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
@@ -386,6 +386,7 @@ public class FsActionExecutor extends ActionExecutor {
      * @param fsConf
      * @param nameNodePath
      * @param path
+     * @param skipTrash flag to skip the trash.
      * @throws ActionExecutorException
      */
     public void delete(Context context, XConfiguration fsConf, Path nameNodePath, Path path,
boolean skipTrash)

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java b/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
index 23e1f69..dc17950 100644
--- a/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
+++ b/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
@@ -1359,6 +1359,8 @@ public class JavaActionExecutor extends ActionExecutor {
      * Useful for overriding in actions that do subsequent job runs
      * such as the MapReduce Action, where the launcher job is not the
      * actual job that then gets monitored.
+     * @param action
+     * @return external ID.
      */
     protected String getActualExternalId(WorkflowAction action) {
         return action.getExternalId();
@@ -1377,7 +1379,7 @@ public class JavaActionExecutor extends ActionExecutor {
     /**
      * Adds action-specific environment variables. Default implementation is no-op.
      * Subclasses should override this method if necessary.
-     *
+     * @param env action specific environment variables stored as Map of key and value.
      */
     protected void addActionSpecificEnvVars(Map<String, String> env) {
         // nop

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java b/core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
index 5097f79..7e33485 100644
--- a/core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
+++ b/core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
@@ -108,6 +108,7 @@ public class SshActionExecutor extends ActionExecutor {
      *
      * @param context action execution context.
      * @param action action object.
+     * @throws org.apache.oozie.action.ActionExecutorException
      */
     @Override
     public void check(Context context, WorkflowAction action) throws ActionExecutorException
{
@@ -167,6 +168,7 @@ public class SshActionExecutor extends ActionExecutor {
      *
      * @param context action execution context.
      * @param action object.
+     * @throws org.apache.oozie.action.ActionExecutorException
      */
     @Override
     public void kill(Context context, WorkflowAction action) throws ActionExecutorException
{
@@ -184,6 +186,7 @@ public class SshActionExecutor extends ActionExecutor {
      *
      * @param context action execution context.
      * @param action action object.
+     * @throws org.apache.oozie.action.ActionExecutorException
      */
     @SuppressWarnings("unchecked")
     @Override
@@ -513,6 +516,7 @@ public class SshActionExecutor extends ActionExecutor {
     /**
      * Get action status.
      *
+     * @param context
      * @param action action object.
      * @return status of the action(RUNNING/OK/ERROR).
      * @throws ActionExecutorException thrown if there is any error in getting status.

http://git-wip-us.apache.org/repos/asf/oozie/blob/d6d34022/release-log.txt
----------------------------------------------------------------------
diff --git a/release-log.txt b/release-log.txt
index 2419972..044119a 100644
--- a/release-log.txt
+++ b/release-log.txt
@@ -1,5 +1,6 @@
 -- Oozie 5.0.0 release (trunk - unreleased)
 
+OOZIE-2931 Fix warnings during build for "no @param for" (Artem Ervits via gezapeti)
 OOZIE-2974 Change TestLiteWorkflowAppParser so that it works with Hadoop 3 (asasvari via
gezapeti)
 OOZIE-2977 Fix javafoc error: self-closing element not allowed (Artem Ervits via gezapeti)
 OOZIE-2960 Fix warnings for @return tag has no argument (Artem Ervits via gezapeti)


Mime
View raw message