openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jrba...@apache.org
Subject svn commit: r707655 - in /openjpa/trunk: openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedStatementManagerImpl.java openjpa-project/src/doc/manual/ref_guide_dbsetup.xml
Date Fri, 24 Oct 2008 15:24:21 GMT
Author: jrbauer
Date: Fri Oct 24 08:24:21 2008
New Revision: 707655

URL: http://svn.apache.org/viewvc?rev=707655&view=rev
Log:
OPENJPA-750: Updates to code and doc based on code review comments

Modified:
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedStatementManagerImpl.java
    openjpa/trunk/openjpa-project/src/doc/manual/ref_guide_dbsetup.xml

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedStatementManagerImpl.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedStatementManagerImpl.java?rev=707655&r1=707654&r2=707655&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedStatementManagerImpl.java
(original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/PreparedStatementManagerImpl.java
Fri Oct 24 08:24:21 2008
@@ -250,22 +250,10 @@
             try {
                 SQLWarning warn = stmt.getWarnings();
                 while (warn != null) {
-                    logSQLWarning(warn);
+                    _log.trace(_loc.get("sql-warning", warn.getMessage()));
                     warn = warn.getNextWarning();
-                } while (warn != null);
+                }
             } catch (SQLException e) {}
         }
     }
-
-    /*
-     * Log the SQLWarning message.  Some drivers report expected conditions 
-     * such as "no rows returned" as a warning.  These types of messages can 
-     * clutter up the default log very quickly, so trace level will be used to
-     * log SQL warnings.
-     */
-    private void logSQLWarning(SQLWarning warn) {
-        if (warn != null) {
-            _log.trace(_loc.get("sql-warning", warn.getMessage()));
-        }
-    }
 }

Modified: openjpa/trunk/openjpa-project/src/doc/manual/ref_guide_dbsetup.xml
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-project/src/doc/manual/ref_guide_dbsetup.xml?rev=707655&r1=707654&r2=707655&view=diff
==============================================================================
--- openjpa/trunk/openjpa-project/src/doc/manual/ref_guide_dbsetup.xml (original)
+++ openjpa/trunk/openjpa-project/src/doc/manual/ref_guide_dbsetup.xml Fri Oct 24 08:24:21
2008
@@ -3377,7 +3377,7 @@
 properties:
             </para>
             <itemizedlist>
-                <listitem id="OracleDictionary.IgnoreNumericTruncation">
+                <listitem id="SybaseDictionary.IgnoreNumericTruncation">
                     <para>
                     <indexterm>
                         <primary>



Mime
View raw message