openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwo...@apache.org
Subject svn commit: r954689 - /openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/identifier/IdentifierRule.java
Date Tue, 15 Jun 2010 01:29:53 GMT
Author: dwoods
Date: Tue Jun 15 01:29:53 2010
New Revision: 954689

URL: http://svn.apache.org/viewvc?rev=954689&view=rev
Log:
OPENJPA-1700 Findbugs - The initial value of this parameter is ignored, and the parameter
is overwritten here. This often indicates a mistaken belief that the write to the parameter
will be conveyed back to the caller.

Modified:
    openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/identifier/IdentifierRule.java

Modified: openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/identifier/IdentifierRule.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/identifier/IdentifierRule.java?rev=954689&r1=954688&r2=954689&view=diff
==============================================================================
--- openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/identifier/IdentifierRule.java
(original)
+++ openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/identifier/IdentifierRule.java
Tue Jun 15 01:29:53 2010
@@ -144,7 +144,7 @@ public class IdentifierRule {
     }
 
     public void setDelimitReservedWords(boolean delimitReservedWords) {
-        delimitReservedWords = _delimitReservedWords;
+        _delimitReservedWords = delimitReservedWords;
     }
 
     public boolean getDelimitReservedWords() {



Mime
View raw message