openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwo...@apache.org
Subject svn commit: r956687 - /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/CollectionParam.java
Date Mon, 21 Jun 2010 20:39:48 GMT
Author: dwoods
Date: Mon Jun 21 20:39:47 2010
New Revision: 956687

URL: http://svn.apache.org/viewvc?rev=956687&view=rev
Log:
OPENJPA-1700 FindBugs - was checking array and not member for null

Modified:
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/CollectionParam.java

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/CollectionParam.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/CollectionParam.java?rev=956687&r1=956686&r2=956687&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/CollectionParam.java
(original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/CollectionParam.java
Mon Jun 21 20:39:47 2010
@@ -157,7 +157,7 @@ public class CollectionParam
                     getMappingRepositoryInstance().getMapping((Class) val,
                         ctx.store.getContext().getClassLoader(), true);
                     pstate.disc[i] = pstate.mapping[i].getDiscriminator();
-                    pstate.discValue[i] = pstate.disc != null ?
+                    pstate.discValue[i] = pstate.disc[i] != null ?
                         pstate.disc[i].getValue() : null;
                 }
             } else if (ImplHelper.isManageable(val)) {



Mime
View raw message