openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwo...@apache.org
Subject svn commit: r956696 - in /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc: kernel/exps/PCPath.java sql/RowManagerImpl.java sql/SelectImpl.java
Date Mon, 21 Jun 2010 21:16:39 GMT
Author: dwoods
Date: Mon Jun 21 21:16:37 2010
New Revision: 956696

URL: http://svn.apache.org/viewvc?rev=956696&view=rev
Log:
OPENJPA-1700 FindBugs - equals() method does not check for null argument

Modified:
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/PCPath.java
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/RowManagerImpl.java
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/PCPath.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/PCPath.java?rev=956696&r1=956695&r2=956696&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/PCPath.java
(original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/PCPath.java
Mon Jun 21 21:16:37 2010
@@ -1147,6 +1147,8 @@ public class PCPath
         }
 
         public boolean equals(Object other) {
+            if (other == null)
+                return false;
             if (other == this)
                 return true;
             Action a = (Action) other;

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/RowManagerImpl.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/RowManagerImpl.java?rev=956696&r1=956695&r2=956696&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/RowManagerImpl.java
(original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/RowManagerImpl.java
Mon Jun 21 21:16:37 2010
@@ -284,6 +284,8 @@ public class RowManagerImpl
         }
 
         public boolean equals(Object other) {
+            if (other == null)
+                return false;
             if (other == this)
                 return true;
 

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java?rev=956696&r1=956695&r2=956696&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java (original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/SelectImpl.java Mon
Jun 21 21:16:37 2010
@@ -2266,6 +2266,8 @@ public class SelectImpl
         }
 
         public boolean equals(Object other) {
+            if (other == null)
+                return false;
             if (other == this)
                 return true;
             if (other.getClass() != getClass())



Mime
View raw message