openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Labusch <labu...@gmail.com>
Subject Re: [Call-for-Review] code changes for more powerful smarttag extensions
Date Wed, 20 Mar 2013 09:26:31 GMT
Am Freitag, 15. März 2013, 07:34:17 schrieb Ariel Constenla-Haile:
> On Fri, Mar 15, 2013 at 10:45:56AM +0100, Jürgen Schmidt wrote:
> > On 3/15/13 10:20 AM, Ariel Constenla-Haile wrote:
> > > On Wed, Mar 13, 2013 at 02:30:26PM +0100, Jürgen Schmidt wrote:
> > >> - a missing include of XInterface in the new IDL
> > >> XMarkingAccess.idl, IDL compile error on Mac, surprising that it
> > >> worked for you
> > > 
> > > This is a bug, the one that removed the need for explicitly
> > > inheriting from XInterface should have taken care for not needing
> > > to include the IDL, what sounds like a non-sense (do not explicitly
> > > inherit, but include the header!).
> > 
> > I agree that it's a bug
> > 
> > >> The interface name "XMarkingAccess" and the method name
> > >> "invalidateMarkings" sounds somewhat strange but I have to
> > >> confess that I don't have a much better name in place. Maybe
> > >> somebody else has a good name in mind?
> > > 
> > > IMHO what it does is more problematic than how it's named; see my
> > > comment on the bug.
> > 
> > issue https://issues.apache.org/ooo/show_bug.cgi?id=121733
> 
> Not this one, but https://issues.apache.org/ooo/show_bug.cgi?id=121732
> invalidation should be triggered on a TextMarkupType base, just like in
> XFlatParagraph::setChecked, otherwise a smart tag extension triggers
> unnecessary spell and grammar checking.
> 
> 
> Regards

I integrated your suggestions for improvement
and updated the related bugzilla entries.

Jürgen tried to apply the separate patches to the AOO trunk sources and 
reported that some of the patch-files were broken. 
Therefore, I have regenerated the patch files and submitted them again:

https://issues.apache.org/ooo/show_bug.cgi?id=121730

https://issues.apache.org/ooo/show_bug.cgi?id=121731

https://issues.apache.org/ooo/show_bug.cgi?id=121732

https://issues.apache.org/ooo/show_bug.cgi?id=121733

https://issues.apache.org/ooo/show_bug.cgi?id=121734

Regards,
Kai Labusch

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message