openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armin Le Grand <Armin.Le.Gr...@me.com>
Subject Re: [Call for review]123515 - Import the sample PPTX(with one slide) to AOO, the shape in slide is applied a default color incorrectly ( should be transparent)
Date Fri, 25 Oct 2013 08:30:21 GMT
     Hi Clarence,

On 25.10.2013 03:25, Clarence GUO wrote:
> So Armin, as you said "We have currently no internal concept to do
> something like that, and no support neither in ODF nor in the UNO API nor
> in the core." and "with 'none' is better than to fill with solid color, but
> will destroy all that 'hole' effects.", do you think it is acceptable if we
> temporarily map it to 'no-fill" as a fix and waiting for ODF, UNO API, core
> can all support it then do a fully support?

Exactly; that's what I would do for now.

Also we would need to discuss about what we will need to make that work 
in a future version. To decide that, we need mor knowledge about:
- How to do in core
- How to do in API
- How in ODF

To decide that it would be useful if you would try to find out what is 
done in the MS formats to save/load it; to know this will be essential 
to be able to im/export this. Is it a special FillType? Is it just a 
flag somewhere at the object overriding FillType? Stuff like that.

Without knowing this I see that this is just a bollean on an object; 
this could be a new value for API and ODF or a 6th value for FillType. 
2nd approach may be problematic; if e.g. the FillType in the API is an 
enum it will not be expendable in a compatible way. Also in ODF all 
installed AOO/OOO's out there will not know what to do when stumbling 
over an unknown FillType. Thus, maybe just a new flag 'BackgroundFill = 
true/false' may be more safe.
That again has to be added not only to the shape, but to the attributes 
and styles of AOO.

BTW: Is this a Draw/Impress only feature request or exists something 
similar for Writer/Calc...?

>
> Sincerely
> Clarence
>
>
> 2013/10/24 Armin Le Grand <Armin.Le.Grand@me.com>
>
>>      Hi Clarence,
>>
>>
>> On 24.10.2013 11:00, Clarence GUO wrote:
>>
>>> I read ODF 1.2 standard, and found for draw:fill it only defined 5 values:
>>> none, solid, gradient, hatch, bitmap. There is not a value for
>>> usebackgroundfill. So seems if we want to fully support this attribute, we
>>> must change ODF standard first.
>>> And finally I found the difference between "no fill" and "use slide
>>> background fill". If the shape is inside the slide area, there's no
>>> difference. But once move the shape outside of the slide area, if applied
>>> "use slide background fill", the shape can still fill the background from
>>> the slide just as it increase the size of canvas; but for shapes applied
>>> "no fill", the background will become empty.
>>>
>> There will be more differences when objects overlap. This is indeed the
>> only useful usage of that FillType in MS; it allows to create the impresson
>> of 'holes' in any objects by forcing the page background to be painted at
>> that place. Thus, replacing with 'none' is better than to fill with solid
>> color, but will destroy all that 'hole' effects.
>> We have currently no internal concept to do something like that, and no
>> support neither in ODF nor in the UNO API nor in the core.
>>
>> Sincerely,
>>      Armin
>>
>>
>>
>>> 2013/10/24 Steve Yin <steve.yin.aoo@gmail.com>
>>>
>>>   Hi Clarence,
>>>> After checking the feature in MSO and comparing with your patch, I found
>>>> that the "fill with background" cannot simply map to "no fill". Is there
>>>> a
>>>> way to implement a real "fill with background" feature in AOO? Thanks.
>>>>
>>>>
>>>> On Thu, Oct 24, 2013 at 4:16 PM, Clarence GUO <clarence.guo.bj@gmail.com
>>>>
>>>>> wrote:
>>>>> Hi~
>>>>> I submitted a path for 123515
>>>>> https://issues.apache.org/ooo/**show_bug.cgi?id=123515<https://issues.apache.org/ooo/show_bug.cgi?id=123515>
>>>>> .
>>>>> Root cause analysis and solution description please see my comment in
>>>>>
>>>> above
>>>>
>>>>> URL
>>>>> Please help to review.
>>>>> Thanks
>>>>>
>>>>> Clarence
>>>>>
>>>>>
>>>> --
>>>> Best Regards,
>>>>
>>>> Steve Yin
>>>>
>>>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.**apache.org<dev-unsubscribe@openoffice.apache.org>
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message