openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andre Fischer <awf....@gmail.com>
Subject Re: [REVIEW REQUEST] Re: review granted: [Issue 124553] Highlight of table with comment and text causes crash : [Attachment 83037] Initialize pointers in ScAccessibleCell contructor.
Date Tue, 01 Apr 2014 11:14:57 GMT
On 01.04.2014 12:11, Oliver-Rainer Wittmann wrote:
> Hi,
>
> On 01.04.2014 11:04, bugzilla@apache.org wrote:
>> Oliver-Rainer Wittmann <orw@apache.org> has granted  review:
>> Issue 124553: Highlight of table with comment and text causes crash
>> https://issues.apache.org/ooo/show_bug.cgi?id=124553
>>
>> Attachment 83037: Initialize pointers in ScAccessibleCell contructor.
>> https://issues.apache.org/ooo/attachment.cgi?id=83037&action=edit
>>
>>
>> ------- Additional Comments from Oliver-Rainer Wittmann <orw@apache.org>
>> patch is fine, but additionally method <SwAccessibleCell::GetTable()> 
>> which
>> sets the forgotten initialized members is not needed. code will be 
>> moved into
>> constructor.
>>
>
> I have refined the patch as stated and made it already available on 
> trunk, revision 1583589

Patch looks good.

-Andre

>
> Please provide me a review.
>
> Thx in advance,
> Oliver.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message