openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From J├╝rgen Schmidt <jogischm...@gmail.com>
Subject Re: svn commit: r1591060 [12/15] - in /openoffice/trunk/main: helpcontent2/source/text/scalc/01/ helpcontent2/source/text/shared/01/ helpcontent2/source/text/simpress/01/ helpcontent2/source/text/smath/01/ helpcontent2/source/text/swriter/01/ helpcontent2/...
Date Wed, 30 Apr 2014 08:21:29 GMT
On 4/29/14 10:56 PM, Pedro Giffuni wrote:
> Fixed as of r1591100, thanks!.
> 
> Sorry, I knew some of this could happen.
> 
> Unfortunately AOO is broken with FreeBSD 10+ (clang/libc++ has bridge
> issues) so
> my testing was limited. It also means I won't be doing much AOO in a while.

mmh, I don't know if this kind of bulk commits are really helpful. It's
nearly impossible to review them. Ok we will see build breakers but I
would prefer if we can at least announce such changes in front of the
change. I was surprised when I updated my local repo ...

And of course I am not sure if it is really so useful. Yes it's nice to
have this spelling errors fixed and I do it as well when I notice them.

But I am no friend of whitespace cleanup or stuff like this without
substantial changes/fixes.

Juergen

> 
> Pedro.
> 
> On 04/29/14 15:46, Ariel Constenla-Haile wrote:
>> On Tue, Apr 29, 2014 at 07:12:03PM -0000, pfg@apache.org wrote:
>>> Modified:
>>> openoffice/trunk/main/offapi/com/sun/star/embed/XTransactionListener.idl
>>> URL:
>>> http://svn.apache.org/viewvc/openoffice/trunk/main/offapi/com/sun/star/embed/XTransactionListener.idl?rev=1591060&r1=1591059&r2=1591060&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> openoffice/trunk/main/offapi/com/sun/star/embed/XTransactionListener.idl
>>> (original)
>>> +++
>>> openoffice/trunk/main/offapi/com/sun/star/embed/XTransactionListener.idl
>>> Tue Apr 29 19:11:53 2014
>>> @@ -41,21 +41,21 @@ module com {  module sun {  module star
>>>     
>>> //============================================================================
>>>
>>>    -/** makes it possible to receive events when a transacted object
>>> is commited
>>> +/** makes it possible to receive events when a transacted object is
>>> committed
>>>       or reverted.
>>>    */
>>>   published interface XTransactionListener:
>>> com::sun::star::lang::XEventListener
>>>   {
>>>      
>>> //------------------------------------------------------------------------
>>>
>>> -    /** is called just before the object is commited.
>>> +    /** is called just before the object is committed.
>>>        */
>>>       void preCommit( [in] com::sun::star::lang::EventObject aEvent )
>>>           raises( ::com::sun::star::uno::Exception );
>>>        
>>> //------------------------------------------------------------------------
>>>
>>> -    /** is called after the object is commited.
>>> +    /** is called after the object is committed.
>>>        */
>>> -    void commited( [in] com::sun::star::lang::EventObject aEvent );
>>> +    void committed( [in] com::sun::star::lang::EventObject aEvent );
>> This breaks the build and is an incompatible change in a published API.
>>
>>
>> Regards
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message