openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kay Schenk <kay.sch...@gmail.com>
Subject Re: Very simple first patch
Date Fri, 14 Nov 2014 00:04:02 GMT


On 11/13/2014 03:10 PM, Andrea Pescetti wrote:
> On 13/11/2014 Michal Hriƈ wrote:
>> I made very simple patch.
>> http://people.apache.org/~hrin/dejavu/
> 
> Looks quite correct. The normal way would be to open an issue of type
> PATCH and attach your patch. Make just one .patch file, obtained with
> svn diff or git diff. And don't forget to send the link here to connect
> it to this discussion.
> 
>> Please review, and feel free to add it to trunk if it will be good.
>> And add comments if I'm doing something wrong.
> 
> I didn't test it yet, but I would only double-check that replacing the
> ZIP file with a tar.gz archive does not require other changes. The rest
> looks good.
> 
>> It is a update of external package :)
> 
> And here is a problem, but it doesn't depend on you. Policy so far has
> been: we download build-time dependencies from the Extensions site and
> from Apache Extras.



Can we get a memory refresher on why we can't use the svn versions of
these external sources directly?

See:
http://svn.apache.org/viewvc/openoffice/trunk/ext_sources/

There's this message in /main/external_deps.lst ...
# Must not fallback to svn
#
SVN_TRUNK=http://svn.apache.org/repos/asf/!svn/bc/1336449/incubator/ooo/trunk/ext_sources/


 If Apache Extras (currently part of Google Code) do
> not allow us to upload files any longer, then this is the first
> occurrence of a problem that we have largely anticipated but not solved
> yet. This shouldn't stop us from updating libraries, but for sure we
> (the entire Apache Foundation, not OpenOffice only) must find a viable
> replacement before the next release.
> 
> Regards,
>   Andrea.

It seems like the testing from the new SourceForge are is going pretty
well...

http://markmail.org/message/4p3klhqkkvszmwav

Maybe time for some additional testing from:
http://sourceforge.net/projects/oooextras.mirror/files/

I'll make local changes and test with this as new OOO_EXTRAS area.

Who would have rights to update these files on SF?


-- 
-------------------------------------------------------------------------
MzK

"One must still have chaos in oneself to be able to give birth
 to a dancing star."
                                 -- Friedrich Nietzsche

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message