openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis E. Hamilton" <dennis.hamil...@acm.org>
Subject RE: svn commit: r1745006 [3/9] - in /openoffice/trunk/main: ./ accessibility/inc/accessibility/standard/ autodoc/inc/ary/idl/ avmedia/source/framework/ basctl/source/basicide/ basctl/source/inc/ basegfx/inc/basegfx/color/ basegfx/inc/basegfx/polygon/ base
Date Sun, 22 May 2016 18:48:23 GMT
It is extremely difficult to review these omnibus patches, especially since some of the language
problems that are preserved are distracting.  At the same time, it is too easy to just want
to assume that there is no incorrect change buried among all of the fixes to "wich", "initalize"
and other misspellings and how they seem to have been perpetuated with extensive copy-paste
manipulations throughout major sections of the code.

I am stopping without having reviewed 2/9 and 6/9 so far.  I will continue when I am rested
and can pay closer attention.

The observations below are simply samples that I am reporting as part of enduring the review
process.  There were many more than these few.

 - Dennis

> -----Original Message-----
> From: pfg@apache.org [mailto:pfg@apache.org]
> Sent: Saturday, May 21, 2016 18:05
> To: commits@openoffice.apache.org
> Subject: svn commit: r1745006 [3/9] - in /openoffice/trunk/main: ./
> accessibility/inc/accessibility/standard/ autodoc/inc/ary/idl/
> avmedia/source/framework/ basctl/source/basicide/ basctl/source/inc/
> basegfx/inc/basegfx/color/ basegfx/inc/basegfx/polygon/ baseg...
> 
[orcmid] 

Reviewing for correctness of the patches themselves only, I have to go through a reply and
ignore the grammar and language defects that are left intact, checking only that the changes
are not dangerous in any manner.  I delete after reviewing each modification.

It is difficult.  There are hundreds of wording defects that are retained, as if the patched
locations have not actually been examined.  I am leaving them so I can get through this mind-numbing
review process as easily as possible.

[ ... ]


> -     * @param buttonName the name of the button wich should be chlicked
> +     * @param buttonName the name of the button which should be
> chlicked
[orcmid] 

  And "chlicked" is my favorite overlooked typo so far.

[ ... ]


> -    // Its not well known identifier - but may be a pure key code
> formated as string ...
> +    // Its not well known identifier - but may be a pure key code
> formatted as string ...
[orcmid] 

Misses "It's not a well-known ..." although "It's" is found sometimes.  Curious.

[ ... ]

 
> Modified:
> openoffice/trunk/main/framework/source/dispatch/mailtodispatcher.cxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/source/disp
> atch/mailtodispatcher.cxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/source/dispatch/mailtodispatcher.cxx
> (original)
> +++ openoffice/trunk/main/framework/source/dispatch/mailtodispatcher.cxx
> Sun May 22 01:05:14 2016
> @@ -138,7 +138,7 @@ MailToDispatcher::~MailToDispatcher()
>      @short      decide if this dispatch implementation can be used for
> requested URL or not
>      @descr      A protocol handler is registerd for an URL pattern
> inside configuration and will
>                  be asked by the generic dispatch mechanism inside
> framework, if he can handle this
> -                special URL wich match his registration. He can agree
> by returning of a valid dispatch
> +                special URL which match his registration. He can agree
> by returning of a valid dispatch
>                  instance or disagree by returning <NULL/>.
>                  We don't create new dispatch instances here really - we
> return THIS as result to handle it
>                  at the same implementation.

[orcmid] 

The use of "He" is often a case of wording by someone whose native language has more gender
than employed in English. "We" and treating the software as an actor tends to be avoided for
other reasons.

There are many situations like this that are overlooked in the code that is patched.  

[ ... ]



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message