openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis E. Hamilton" <dennis.hamil...@acm.org>
Subject RE: svn commit: r1745006 [3/9] - in /openoffice/trunk/main: ./ accessibility/inc/accessibility/standard/ autodoc/inc/ary/idl/ avmedia/source/framework/ basctl/source/basicide/ basctl/source/inc/ basegfx/inc/basegfx/color/ basegfx/inc/basegfx/polygon/ base
Date Sun, 22 May 2016 18:48:23 GMT
In reviewing these 9 SVN reports a bit more closely than simply checking the -/+ lines, I see
that these mechanical changes miss some material ones, if clarity of language is the goal.
 I also observe that some of the grammatical cases are typical of ways some non-native English
speakers translate from their own language.

I do not want to catalog all of these.  I just want to point out some of the cases that might
or might not be addressed more carefully when someone happens to be working on these individual
files and not applying some sort of bulk result that defies review.

 - Dennis

> -----Original Message-----
> From: pfg@apache.org [mailto:pfg@apache.org]
> Sent: Saturday, May 21, 2016 18:05
> To: commits@openoffice.apache.org
> Subject: svn commit: r1745006 [3/9] - in /openoffice/trunk/main: ./
> accessibility/inc/accessibility/standard/ autodoc/inc/ary/idl/
> avmedia/source/framework/ basctl/source/basicide/ basctl/source/inc/
> basegfx/inc/basegfx/color/ basegfx/inc/basegfx/polygon/ baseg...
> 
> Modified:
> openoffice/trunk/main/framework/inc/helper/persistentwindowstate.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/inc/helper/
> persistentwindowstate.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/inc/helper/persistentwindowstate.hxx
> (original)
> +++ openoffice/trunk/main/framework/inc/helper/persistentwindowstate.hxx
> Sun May 22 01:05:14 2016
> @@ -148,7 +148,7 @@ class PersistentWindowState :   // inter
>                      needed to create needed uno resources.
> 
>              @param  xFrame
> -                    contains the component, wich must be identified.
> +                    contains the component, which must be identified.
> 
>              @return [string]
>                      a module identifier for the current frame
> component.
> @@ -193,7 +193,7 @@ class PersistentWindowState :   // inter
> 
>              @param  sModuleName
>                      identifies the application module, where the
> -                    information should be setted on.
> +                    information should be set on.
[orcmid] 

It might be sufficient to say "where the information is to be set." 
> 
>              @param  sWindowState
>                      contains the information about position and size.
> 
> Modified:
> openoffice/trunk/main/framework/inc/helper/propertysetcontainer.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/inc/helper/
> propertysetcontainer.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/inc/helper/propertysetcontainer.hxx
> (original)
> +++ openoffice/trunk/main/framework/inc/helper/propertysetcontainer.hxx
> Sun May 22 01:05:14 2016
> @@ -39,7 +39,7 @@ namespace framework
>  {
> 
>  class FWE_DLLPUBLIC PropertySetContainer : public
> com::sun::star::container::XIndexContainer	,
> -							 public ThreadHelpBase
> 						,	// Struct for right initalization
> of mutex member! Must be first of baseclasses.
> +							 public ThreadHelpBase
> 						,	// Struct for right initialization
> of mutex member! Must be first of baseclasses.
>  							 public ::cppu::OWeakObject
>  {
>  	public:
> 
> Modified: openoffice/trunk/main/framework/inc/helper/titlebarupdate.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/inc/helper/
> titlebarupdate.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/inc/helper/titlebarupdate.hxx
> (original)
> +++ openoffice/trunk/main/framework/inc/helper/titlebarupdate.hxx Sun
> May 22 01:05:14 2016
> @@ -197,7 +197,7 @@ class TitleBarUpdate : // interfaces
>                      of our frame.
> 
>              @param  xFrame
> -                    contains the component, wich must be identified.
> +                    contains the component, which must be identified.
> 
>              @param  rInfo
>                      describe the module in its details.
> 
[orcmid] 

Probably "describes the module."

[ ... ]


> Modified: openoffice/trunk/main/framework/inc/services/autorecovery.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/inc/service
> s/autorecovery.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/inc/services/autorecovery.hxx
> (original)
> +++ openoffice/trunk/main/framework/inc/services/autorecovery.hxx Sun
> May 22 01:05:14 2016
> @@ -128,7 +128,7 @@ struct DispatchParams
>  /**
>      implements the functionality of AutoSave and AutoRecovery
>      of documents - including features of an EmergencySave in
> -    case a GPF occures.
> +    case a GPF occurs.
>   */
>  class AutoRecovery  : public  css::lang::XTypeProvider
>                      , public  css::lang::XServiceInfo
> @@ -761,7 +761,7 @@ class AutoRecovery  : public  css::lang:
>                      only if removing oft he old file was successfully.
[orcmid] 

    "oft he" is probably "of the" above.

>                      If this method returns without an exception -
> everything
>                      was OK. Otherwhise the info struct can be analyzed
> to
[orcmid] 

    "Otherwhise" -> "Otherwise"


> -                    get more information, e.g. when the problem
> occures.
> +                    get more information, e.g. when the problem occurs.
> 
>              @param  sBackupPath
>                      the base path for saving such temp files.
> 
> Modified: openoffice/trunk/main/framework/inc/services/desktop.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/inc/service
> s/desktop.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/inc/services/desktop.hxx (original)
> +++ openoffice/trunk/main/framework/inc/services/desktop.hxx Sun May 22
> 01:05:14 2016
> @@ -489,7 +489,7 @@ class Desktop   :   // interfaces
>            * Because these desktop instance closes documents and informs
> listener
[orcmid] 

    Probably "* Because these desktop instances close documents and inform"


>            * only ... it does not really shutdown the whole application.
[orcmid] 

    Probably "* only ... do not shutdown ... "


>            *
> -          * Btw: That wouldnt be possible by design ... because
> Desktop.terminate()
> +          * Btw: That wouldn't be possible by design ... because
> Desktop.terminate()
>            * has to return a boolean value about success ... it can't
> really shutdown the
>            * process .-)
>            *
> 
> Modified:
> openoffice/trunk/main/framework/inc/services/frameloaderfactory.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/framework/inc/service
> s/frameloaderfactory.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/framework/inc/services/frameloaderfactory.hxx
> (original)
> +++ openoffice/trunk/main/framework/inc/services/frameloaderfactory.hxx
> Sun May 22 01:05:14 2016
> @@ -81,7 +81,7 @@ struct tIMPLExtractedArguments
>  /*-
> ************************************************************************
> ************************************//**
>  	@short		factory to create frameloader-objects
>  	@descr		These class can be used to create new loader for
> specified contents.
> -				We use cached values of the registry to lay down,
> wich frameloader match
> +				We use cached values of the registry to lay down,
> which frameloader match
[orcmid] 

   Probably one of "which frameloader matches" or
                   "which frameloaders match"

There's more.  

The point is that there is more involved to this kind of cleanup than finding certain repeated
misspellings.  Also, some of these modules are of particular interest in the researching of
some crashers that are plaguing us.  

[ ... ]


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message