openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis E. Hamilton" <dennis.hamil...@acm.org>
Subject RE: svn commit: r1745006 [1/9] - in /openoffice/trunk/main: ./ accessibility/inc/accessibility/standard/ autodoc/inc/ary/idl/ avmedia/source/framework/ basctl/source/basicide/ basctl/source/inc/ basegfx/inc/basegfx/color/ basegfx/inc/basegfx/polygon/ base
Date Sun, 22 May 2016 18:48:23 GMT
@pfg and anyone else tempted to do any more of this,


 1. Please do not create omnibus commits that, however easy to produce, 

    a. Are awfully burdensome to review 

    b. Are not tied to focused bugzilla issues providing an account of
       particular defects

    c. Do not have anything to do with repairing a material issue 
       impacting the maintenance and usability of the product

    d. And might presume too much about the language skills and even
       the native languages of previous contributors 

 2. One way to make the correction of comments and debugging messages more straightforward
is to do so on individual files when attention is on them for some useful purpose, such as
forensic analysis or other maintenance.

That is, touch-ups of accompanying comments and messages are best done incidental to working
on a file for some practical purpose and then done in a way where review is straightforward.

 - Dennis

Some comments inline ...

> -----Original Message-----
> From: pfg@apache.org [mailto:pfg@apache.org]
> Sent: Saturday, May 21, 2016 18:05
> To: commits@openoffice.apache.org
> Subject: svn commit: r1745006 [1/9] - in /openoffice/trunk/main: ./
> accessibility/inc/accessibility/standard/ autodoc/inc/ary/idl/
> avmedia/source/framework/ basctl/source/basicide/ basctl/source/inc/
> basegfx/inc/basegfx/color/ basegfx/inc/basegfx/polygon/ baseg...
> 
> Author: pfg
> Date: Sun May 22 01:05:14 2016
> New Revision: 1745006
> 
> URL: http://svn.apache.org/viewvc?rev=1745006&view=rev
> Log:
> Spelling, spelling ...
> 
> Why worry about some sprinkled German when we haven't yet learned
> English.
[orcmid] 

It may be a mistake to presume that these mistakes, some of which are clearly replicated/perpetuated
as copy-paste errors, were produced by native English speakers with mastery of English prose.

Of course, native speakers make mistakes and overlook mistakes too.  It would be valuable
to have some tolerance for the diversity of our community and also focus on more pressing
matters.


> 
> Modified:
> 
> openoffice/trunk/main/accessibility/inc/accessibility/standard/vclxacces
> sibletextfield.hxx
[orcmid] 

[************ ... AND ****HUNDREDS**** MORE LIKE THIS ... *************** ]



> Modified:
> openoffice/trunk/main/accessibility/inc/accessibility/standard/vclxacces
> sibletextfield.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/accessibility/inc/acc
> essibility/standard/vclxaccessibletextfield.hxx?rev=1745006&r1=1745005&r
> 2=1745006&view=diff
> ========================================================================
> ======
> ---
> openoffice/trunk/main/accessibility/inc/accessibility/standard/vclxacces
> sibletextfield.hxx (original)
> +++
> openoffice/trunk/main/accessibility/inc/accessibility/standard/vclxacces
> sibletextfield.hxx Sun May 22 01:05:14 2016
> @@ -37,7 +37,7 @@ typedef ::cppu::ImplHelper1<
> 
>  /** This class represents non editable text fields.  The object passed
> to
>      the constructor is expected to be a list (a <type>ListBox</type> to
> be
> -    more specific).  From this allways the selected item is token to be
> made
> +    more specific).  From this always the selected item is token to be
> made
>      accessible by this class.  When the selected item changes then also
> the
>      exported text changes.
>  */
[orcmid] 

Although it is nice to correct "allways" it appears that "token" in the corrected line is
meant to be "taken".

> 
> Modified: openoffice/trunk/main/autodoc/inc/ary/idl/i_ce.hxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/autodoc/inc/ary/idl/i
> _ce.hxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/autodoc/inc/ary/idl/i_ce.hxx (original)
> +++ openoffice/trunk/main/autodoc/inc/ary/idl/i_ce.hxx Sun May 22
> 01:05:14 2016
> @@ -44,7 +44,7 @@ namespace idl
> 
>  /** @resp Base class for all IDL code entities.
> 
> -    A @->CodeEntity is a namespace, type, data or function, which
> occures in
> +    A @->CodeEntity is a namespace, type, data or function, which
> occurs in
>      the parsed UNO IDL code and is described and/or commented within
> the
>      Autodoc repository.
> 

[orcmid] 

[********************* ************************** ************************ ]

And the ***HUNDREDS*** More like this might have been amusing to root out with search and
replace while imposing an intolerable burden on review, with no connection to a JIRA issue
and no actual repair of anything that impacts the usability of the product.

[ ... ]


 
> Modified:
> openoffice/trunk/main/basegfx/source/polygon/b2dlinegeometry.cxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/basegfx/source/polygo
> n/b2dlinegeometry.cxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/basegfx/source/polygon/b2dlinegeometry.cxx
> (original)
> +++ openoffice/trunk/main/basegfx/source/polygon/b2dlinegeometry.cxx Sun
> May 22 01:05:14 2016
> @@ -875,7 +875,7 @@ namespace basegfx
> 
>                              if(ORIENTATION_NEUTRAL == aOrientation)
>                              {
> -                                   // they are parallell or empty; if
> they are both not zero and point
> +                                   // they are parallel or empty; if
> they are both not zero and point
>                                     // in opposite direction, a half-
> circle is needed
>                                     if(!aTangentPrev.equalZero() &&
> !aTangentEdge.equalZero())
>                                     {

[orcmid] 

[... ******** AD NAUSEUM ******** ... ]

[ ... ]

> Modified: openoffice/trunk/main/basic/source/comp/loops.cxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/basic/source/comp/loo
> ps.cxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/basic/source/comp/loops.cxx (original)
> +++ openoffice/trunk/main/basic/source/comp/loops.cxx Sun May 22
> 01:05:14 2016
> @@ -538,7 +538,7 @@ void SbiParser::Resume()
>  			{
>  				aGen.Gen( _RESUME, 0 );
>  				break;
> -			} // fall thru
> +			} // fall through
>  		case SYMBOL:
>  			if( MayBeLabel() )
>  			{
> @@ -546,7 +546,7 @@ void SbiParser::Resume()
>  				aGen.Gen( _RESUME, nLbl );
>  				Next();
>  				break;
> -			} // fall thru
> +			} // fall through
>  		default:
>  			Error( SbERR_LABEL_EXPECTED );
>  	}
> 
[orcmid] 

[ ... and now GRAMMAR POLICING 'thru' versus 'through'? ************** ]

[ ... ]


> Modified: openoffice/trunk/main/chart2/source/tools/ObjectIdentifier.cxx
> URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/chart2/source/tools/O
> bjectIdentifier.cxx?rev=1745006&r1=1745005&r2=1745006&view=diff
> ========================================================================
> ======
> --- openoffice/trunk/main/chart2/source/tools/ObjectIdentifier.cxx
> (original)
> +++ openoffice/trunk/main/chart2/source/tools/ObjectIdentifier.cxx Sun
> May 22 01:05:14 2016
> @@ -559,7 +559,7 @@ OUString ObjectIdentifier::createParticl
>      OUStringBuffer aRet;
> 
>      Reference< XDiagram > xDiagram( ChartModelHelper::findDiagram(
> xChartModel ) );
> -    //todo: if more than one diagram is implemeted, find the correct
> diagram wich is owner of the given legend
> +    //todo: if more than one diagram is implemeted, find the correct
> diagram which is owner of the given legend
> 
>      aRet.append( ObjectIdentifier::createParticleForDiagram( xDiagram,
> xChartModel ) );
>      aRet.appendAscii(":");
> 
[orcmid] 

Great.  Correcting the text of a TODO without doing anything about the TODO.


PS: "implemeted" is still a misspelling. ***********************************

[ ... ]





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message