openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias Seidel <matthias.sei...@hamburg.de>
Subject Re: get Revision from Git (short Hash)
Date Wed, 14 Aug 2019 14:27:26 GMT
Hi Peter, all,

Am 14.08.19 um 12:16 schrieb Peter Kovacs:
> First we are already on git. The switch has already been completed. If you are unsatisfied
from the plantings then that is fine for me.
>
> I think you have only to modify the print git command from my patch to add the date.
Also I have a variant ready that returns the git-svn-id if on is there.

I don't think this is necessary: We already have the build id, the build
date and now the git hash (which is a unique link to the last commit it
was based on):

https://www.dropbox.com/s/tkal1y9b09vrhse/VirtualBox_Windows%2010%20AOO-Build_14_08_2019_16_14_33.png?dl=0

This is how we did it with SVN, why should we change it?


@Peter:
I made a logical mistake regarding the git-svn-id, so I think your first
patch is totally sufficient.

Regards,

   Matthias

>
> Please see my patch earlier in the thread. 
>
> Am 14. August 2019 10:28:59 MESZ schrieb Andrea Pescetti <pescetti@apache.org>:
>> Dave Fisher wrote:
>>> Put another way does switching to Git require careful discussion of
>> update scenarios?
>>
>> No. Updates use version numbers, that are defined (to some people, this
>>
>> may be a bug rather than a feature!) explicitly in configuration files;
>>
>> so they are not linked at all to the revision control system in use.
>>
>> The revision number/hash is only significant for dev builds, where the 
>> update mechanism does not apply.
>>
>> Regards,
>>   Andrea.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message