openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus <marcus.m...@wtnet.de>
Subject Re: get Revision from Git (short Hash)
Date Sun, 11 Aug 2019 17:56:37 GMT
Am 11.08.19 um 19:40 schrieb Peter Kovacs:
> I have adjusted the Function DetectRevisionId in
> main/solenv/bin/modules/SvnRevision.pm to return the short hash when
> executed in a git repository.
> 
> If it is not a git repository, it will fallback to the SVN logic. The
> short hash includes a newline. I am not sure if that will make any trouble.
> 
> 
> I have attached the patch. Please review. I could not test a complete
> build I have some building issues. (I will send some separated mails.)
> 
> Also I have not checked in because of the lacking N2N test, and since I
> do not know what this newline does.

thanks for the piece of code. Any sideeffects need to be tested of course.

One problem I could image is the About dialog. Showing the Git hash with 
a newline would be not suitable.

Any other problem would be in the build system itself I thin.

So, avoiding the newline would be great.

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message