phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Purtell <apurt...@apache.org>
Subject Re: best development methodology for Apache git?
Date Wed, 29 Jan 2014 19:06:30 GMT
To highlight what Devaraj says, actually Reviewboard (reviews.apache.org)
aka RB has good support for uploading Git generated diffs. I've found it
easier to do that than SVN diffs, so when preparing HBase patches for RB
I'll go through Git locally to get them there.


On Tue, Jan 28, 2014 at 11:09 PM, Devaraj Das <ddas@hortonworks.com> wrote:

> And there is reviewboard which is pretty widely used in HBase for the
> code review (and that works off git repo too)..
>
> On Tue, Jan 28, 2014 at 10:54 PM, Devaraj Das <ddas@hortonworks.com>
> wrote:
> > Hey James, couldn't we use the jira comments as a way to
> > discuss/feedback, even though we use git repo?
> >
> > On Tue, Jan 28, 2014 at 10:47 PM, James Taylor <jamestaylor@apache.org>
> wrote:
> >> I know you HBase guys use svn as your source of truth, but Phoenix is
> using
> >> git. With our old git repo which was hosted on github, we'd typically do
> >> work locally and then send a pull request to the source-of-truth github
> >> repo. That way others could comment on the pending commit before it was
> >> pulled in. Pulling it in could be done with a single click by someone
> with
> >> write privileges.
> >>
> >> Now, though, our source-of-truth is *not* on github, but on a git repo
> >> hosted by Apache. It's only mirrored to github in a read-only manner.
> Plus,
> >> it may be lagging behind the source-of-truth repo.
> >>
> >> What's the best, recommended methodology and ui to use for getting
> feedback
> >> pre-commit?
> >>
> >> Thanks,
> >> James
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>



-- 
Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message