phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-831) First Connection to Phoenix blows up if it is tenant specific
Date Tue, 11 Mar 2014 07:18:43 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930037#comment-13930037
] 

ASF GitHub Bot commented on PHOENIX-831:
----------------------------------------

Github user yaise commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/15#discussion_r10463695
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
    @@ -119,7 +116,36 @@ private static Properties newPropsWithSCN(long scn, Properties props)
{
             props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB, Long.toString(scn));
             return props;
         }
    -    
    --- End diff --
    
    Let me know if the comments here don't make sense. Basically the joy of using java.util.properties'
copy constructor is that it doesn't do a deep copy but holds a reference. getProperty() works
but native map operations like remove or containsKey only work on the map( i.e. this property
instance) and not the one it wraps. So if someone added tenant ID to properties, great ( we
can remove easily) but if someone added it to properties and then wrapped it in another one,
then we have to create a new copy and exclude it. 


> First Connection to Phoenix blows up if it is tenant specific
> -------------------------------------------------------------
>
>                 Key: PHOENIX-831
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-831
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Somesh Sasalatti
>
> Driver driver = DriverManager.getDriver(url);
> Properties props = new Properties();
> final String tenantId = "00Dxx0000001234";
> props.put(PhoenixRuntime.TENANT_ID_ATTRIB, tenantId);
> Connection connection = driver.connect(url, props);
> BOOM!
> I have pull request coming shortly



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message